Skip to content

Commit

Permalink
[giow] (2) Block popups from some weird edge cases that fire 'change'…
Browse files Browse the repository at this point in the history
… events on <select> as a result of script.

Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=25504
Affected topics: HTML

git-svn-id: http://svn.whatwg.org/webapps@8720 340c8d12-0b0e-0410-8428-c7bf67bfef74
  • Loading branch information
Hixie committed Aug 26, 2014
1 parent 0260894 commit 9c24844
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
4 changes: 3 additions & 1 deletion complete.html
Expand Up @@ -37500,7 +37500,9 @@ <h4 id=the-select-element>4.10.7 The <dfn><code>select</code></dfn> element</h4>
a task</a> to first <a href=#fire-a-simple-event id=the-select-element:fire-a-simple-event>fire a simple event</a> that bubbles named <code id=the-select-element:event-input><a href=#event-input>input</a></code> at the <code id=the-select-element:the-select-element-22><a href=#the-select-element>select</a></code> element, and then <a href=#fire-a-simple-event id=the-select-element:fire-a-simple-event-2>fire a simple
event</a> that bubbles named <code id=the-select-element:event-change><a href=#event-change>change</a></code> at the
<code id=the-select-element:the-select-element-23><a href=#the-select-element>select</a></code> element, using the <a href=#user-interaction-task-source id=the-select-element:user-interaction-task-source>user interaction task source</a> as the task
source.</p>
source. If the <a href=#stack-of-script-settings-objects id=the-select-element:stack-of-script-settings-objects>stack of script settings objects</a> was not empty when the user agent was
to <a href=#send-select-update-notifications id=the-select-element:send-select-update-notifications-4>send <code>select</code> update notifications</a>, then the resulting <code id=the-select-element:event-input-2><a href=#event-input>input</a></code> and <code id=the-select-element:event-change-2><a href=#event-change>change</a></code> events must not be
<a href=#concept-events-trusted id=the-select-element:concept-events-trusted>trusted</a>.</p>

<p>The <a href=#concept-form-reset-control id=the-select-element:concept-form-reset-control>reset algorithm</a> for <code id=the-select-element:the-select-element-24><a href=#the-select-element>select</a></code>
elements is to go through all the <code id=the-select-element:the-option-element-25><a href=#the-option-element>option</a></code> elements in the element's <a href=#concept-select-option-list id=the-select-element:concept-select-option-list-17>list of options</a>, set their <a href=#concept-option-selectedness id=the-select-element:concept-option-selectedness-16>selectedness</a> to true if the <code id=the-select-element:the-option-element-26><a href=#the-option-element>option</a></code>
Expand Down
4 changes: 3 additions & 1 deletion index
Expand Up @@ -37500,7 +37500,9 @@ You cannot submit this form when the field is incorrect.</samp></pre>
a task</a> to first <a href=#fire-a-simple-event id=the-select-element:fire-a-simple-event>fire a simple event</a> that bubbles named <code id=the-select-element:event-input><a href=#event-input>input</a></code> at the <code id=the-select-element:the-select-element-22><a href=#the-select-element>select</a></code> element, and then <a href=#fire-a-simple-event id=the-select-element:fire-a-simple-event-2>fire a simple
event</a> that bubbles named <code id=the-select-element:event-change><a href=#event-change>change</a></code> at the
<code id=the-select-element:the-select-element-23><a href=#the-select-element>select</a></code> element, using the <a href=#user-interaction-task-source id=the-select-element:user-interaction-task-source>user interaction task source</a> as the task
source.</p>
source. If the <a href=#stack-of-script-settings-objects id=the-select-element:stack-of-script-settings-objects>stack of script settings objects</a> was not empty when the user agent was
to <a href=#send-select-update-notifications id=the-select-element:send-select-update-notifications-4>send <code>select</code> update notifications</a>, then the resulting <code id=the-select-element:event-input-2><a href=#event-input>input</a></code> and <code id=the-select-element:event-change-2><a href=#event-change>change</a></code> events must not be
<a href=#concept-events-trusted id=the-select-element:concept-events-trusted>trusted</a>.</p>

<p>The <a href=#concept-form-reset-control id=the-select-element:concept-form-reset-control>reset algorithm</a> for <code id=the-select-element:the-select-element-24><a href=#the-select-element>select</a></code>
elements is to go through all the <code id=the-select-element:the-option-element-25><a href=#the-option-element>option</a></code> elements in the element's <a href=#concept-select-option-list id=the-select-element:concept-select-option-list-17>list of options</a>, set their <a href=#concept-option-selectedness id=the-select-element:concept-option-selectedness-16>selectedness</a> to true if the <code id=the-select-element:the-option-element-26><a href=#the-option-element>option</a></code>
Expand Down
5 changes: 4 additions & 1 deletion source
Expand Up @@ -48213,7 +48213,10 @@ You cannot submit this form when the field is incorrect.</samp></pre>
data-x="event-input">input</code> at the <code>select</code> element, and then <span>fire a simple
event</span> that bubbles named <code data-x="event-change">change</code> at the
<code>select</code> element, using the <span>user interaction task source</span> as the task
source.</p>
source. If the <span>stack of script settings objects</span> was not empty when the user agent was
to <span>send <code>select</code> update notifications</span>, then the resulting <code
data-x="event-input">input</code> and <code data-x="event-change">change</code> events must not be
<span data-x="concept-events-trusted">trusted</span>.</p>

<p>The <span data-x="concept-form-reset-control">reset algorithm</span> for <code>select</code>
elements is to go through all the <code>option</code> elements in the element's <span
Expand Down

0 comments on commit 9c24844

Please sign in to comment.