Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in CanvasDrawPath.isPointInPath #10053

Closed
0f-0b opened this issue Jan 12, 2024 · 0 comments · Fixed by #10170
Closed

Typo in CanvasDrawPath.isPointInPath #10053

0f-0b opened this issue Jan 12, 2024 · 0 comments · Fixed by #10170
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: canvas

Comments

@0f-0b
Copy link

0f-0b commented Jan 12, 2024

What is the issue with the HTML Standard?

Both overloads of isPointInPath are specified to “return the result of the is point in path steps given this, null, x, y, and fillRule”. I think the second overload should pass path instead of null to the is point in path steps.
@domenic domenic added good first issue Ideal for someone new to a WHATWG standard or software project topic: canvas labels Jan 12, 2024
MustafaMulla29 pushed a commit to MustafaMulla29/html that referenced this issue Jan 13, 2024
fix/typo issue-whatwg#10053
92a880d
@MustafaMulla29 MustafaMulla29 mentioned this issue Jan 13, 2024
Closed
@tawandamoyo tawandamoyo mentioned this issue Feb 29, 2024
Merged
1 task
domenic pushed a commit that referenced this issue Mar 4, 2024
@tawandamoyo
Fix typo in CanvasDrawPath's isPointInPath()
c3dfba8 
Closes #10053.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: canvas
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix (#10053): typo in CanvasDrawPath.isPointInPath tawandamoyo/html
2 participants
@domenic @0f-0b