Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hit Regions - Speed #1029

Closed
greggman opened this issue Apr 12, 2016 · 0 comments · Fixed by #1942
Closed

Hit Regions - Speed #1029

greggman opened this issue Apr 12, 2016 · 0 comments · Fixed by #1942
Labels
topic: canvas

Comments

@greggman
Copy link

Is canvas hit region dead or is it still expected to be implemented?

In any case, would it not be better if the current transform was setable after the fact? As it is if you make a hitregion and move the thing it represents on the canvas AFAICT you have to delete the old hitregion and make a new one because the transform is only used at creation time. If on the other hand you could set the transform of a hitregion after creation then it would be easy to associate hitregions with things in the canvas. Sure it would only work if their transforms changed, not their content, but it would at least allow one path for fast updating.
@greggman greggman mentioned this issue Apr 12, 2016
Closed
annevk added a commit that referenced this issue Oct 21, 2016
@annevk
Remove canvas element's hit region feature (for now)
a55c2bf 
As currently defined the feature has a number of objections due to it
altering hit testing without there being a real need to do so. The API
can also be simplified to only work with elements rather than
accommodating arbitrary objects.

Fixes #548. Closes #547, closes #849, and closes #1029, due to hit
regions requiring a fresh PR. #1030 is the follow-up issue for new hit
region work.
@annevk annevk mentioned this issue Oct 21, 2016
Merged
annevk added a commit that referenced this issue Oct 21, 2016
@annevk
Remove canvas element's hit region feature (for now)
9d493a3 
As currently defined the feature has a number of objections due to it
altering hit testing without there being a real need to do so. The API
can also be simplified to only work with elements rather than
accommodating arbitrary objects.

Fixes #548. Closes #547, closes #849, and closes #1029, due to hit
regions requiring a fresh PR. #1030 is the follow-up issue for new hit
region work.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Remove canvas element's hit region feature (for now)
25a008c 
As currently defined the feature has a number of objections due to it
altering hit testing without there being a real need to do so. The API
can also be simplified to only work with elements rather than
accommodating arbitrary objects.

Fixes whatwg#548. Closes whatwg#547, closes whatwg#849, and closes whatwg#1029, due to hit
regions requiring a fresh PR. whatwg#1030 is the follow-up issue for new hit
region work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: canvas
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove canvas element's hit region feature (for now) whatwg/html
2 participants
@greggman @annevk