Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script element schematic diagram for async/defer is not readable in dark mode #10546

Closed
jverkoey opened this issue Aug 5, 2024 · 6 comments
Closed

Comments

@jverkoey
Copy link

jverkoey commented Aug 5, 2024

What is the issue with the HTML Standard?

https://html.spec.whatwg.org/multipage/scripting.html#the-script-element

See the following screenshot in Dark Mode:

Screenshot 2024-08-04 at 10 48 53 PM

The same diagram in Light Mode:

Screenshot 2024-08-04 at 10 50 21 PM
@lokendra005

This comment was marked as spam.

@nektro
Copy link

nektro commented Aug 5, 2024

appears okay for me

image

@Kaiido
Copy link
Member

Kaiido commented Aug 5, 2024

Looks like a Safari issue. They apparently don't respect color-scheme: dark light from inside an <img>, nor do they support prefers-color-scheme there btw. Maybe for privacy reasons?
They do however support it when in an <iframe> or <object>, so it might be a workaround.

Other affected sections:

Also the "tracking-vector" image's background should probably be updated for dark-mode, currently only Safari renders a visible finger-print path, thanks to that "issue".

@domenic
Copy link
Member

domenic commented Aug 5, 2024

Let's close this then, and have people file bugs on Safari.

@domenic domenic closed this as completed Aug 5, 2024
@jverkoey
Copy link
Author

jverkoey commented Aug 5, 2024

What's the best way to file this kind of bug against Safari? Should I file a radar?

@nektro
Copy link

nektro commented Aug 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants