Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isindex parsing special case #1088

Closed
domenic opened this issue Apr 21, 2016 · 3 comments
Closed

Remove isindex parsing special case #1088

domenic opened this issue Apr 21, 2016 · 3 comments
Labels
removal/deprecation Removing or deprecating a feature

Comments

@domenic
Copy link
Member

domenic commented Apr 21, 2016 •
edited

Blink and EdgeHTML no longer implement special-case parsing for isindex.

Blink, at least, per https://codereview.chromium.org/96653004/, also removed the special support for first-in-form text controls named "isindex". I haven't tested Edge on that.

We should consider removing it, if at least one of Gecko and WebKit is interested in doing so. I'll file bugs:
@domenic domenic added the removal/deprecation Removing or deprecating a feature label Apr 21, 2016
@annevk
Copy link
Member

annevk commented Apr 21, 2016

Are you Blink did that, it just says "This additionally means that we can remove the special-casing for forms containing as their first element."?

@domenic
Copy link
Member Author

domenic commented Apr 21, 2016

Yes, see https://codereview.chromium.org/96653004/patch/90001/100047 and https://codereview.chromium.org/96653004/patch/90001/100052

@annevk
Copy link
Member

annevk commented Apr 22, 2016

Oooh interesting. That would simplify some things in the URL Standard too.

annevk added a commit that referenced this issue Apr 22, 2016
@annevk
Remove <isindex> and <input name=isindex>
8721d92 
Fixes #1088. Edge and Chrome have removed parser support. Chrome has
removed name=isindex support. And Firefox plans on removing support.
This was referenced Apr 22, 2016
Merged
Closed
annevk added a commit that referenced this issue Apr 22, 2016
@annevk
Remove <isindex> and <input name=isindex>
5c44abc 
The <isindex> parser macro is a potential XSS problem and browsers have therefore started removing support. It is no longer supported by Chrome and Edge. Firefox also plans on removing support.

At least Chrome has also removed <input name=isindex> support and we anticipate other browsers to follow there too.

Fixes #1088.
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Sep 9, 2016
@zcorpan
Test that <input name=isindex> is not supported
99f154d 
See whatwg/html#1088
cscott added a commit to fgnass/domino that referenced this issue Oct 18, 2016
@cscott
Remove special handling of <isindex> tag.
fd18309 
Follows update to HTML5 spec: whatwg/html#1088
@patrickdark patrickdark mentioned this issue Dec 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
removal/deprecation Removing or deprecating a feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk