Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom element state when constructor throws #1396

Closed
kojiishi opened this issue Jun 7, 2016 · 1 comment
Closed

Custom element state when constructor throws #1396

kojiishi opened this issue Jun 7, 2016 · 1 comment
Labels
topic: custom elements Relates to custom elements (as defined in DOM and HTML)

Comments

@kojiishi
Copy link

kojiishi commented Jun 7, 2016

The example 2 of defined illustrates elements are undefined if constructor throws. But if I understand our resolution on #1297 correctly, shouldn't it be defined?

@dominiccooney @domenic
@zcorpan zcorpan added the topic: custom elements Relates to custom elements (as defined in DOM and HTML) label Jun 7, 2016
@domenic
Copy link
Member

domenic commented Jun 7, 2016

Yep, good catch. I'll modify the example to omit super().

domenic added a commit to whatwg/dom that referenced this issue Jun 7, 2016
@domenic
Fix example of "undefined" custom element state
98adcb0 
whatwg/html#1297 led to a series of changes
which cause the custom element state to be set to "defined" by the
HTMLElement constructor. This invalidates the super()-then-throw
example. We instead replace it with an example that fails to call
super().

Fixes whatwg/html#1396.
@domenic domenic mentioned this issue Jun 7, 2016
Merged
annevk pushed a commit to whatwg/dom that referenced this issue Jun 7, 2016
@domenic @annevk
Fix example of "undefined" custom element state
00250fc 
whatwg/html#1297 led to a series of changes
which cause the custom element state to be set to "defined" by the
HTMLElement constructor. This invalidates the super()-then-throw
example. We instead replace it with an example that fails to call
super().

Fixes whatwg/html#1396.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: custom elements Relates to custom elements (as defined in DOM and HTML)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @domenic @kojiishi