-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to render <summary> when it has display style like "table-cell"? #1839
Comments
The spec says
So isn't it well defined what should happen for different 'display' values of the summary, since CSS defines behavior for any 'display' value inside a block box? (In the case of 'table-cell', it's wrapped in an anonymous table and table row.) |
I thought there was agreement that the current spec language is not the behavior people actually want? But I admit I haven't been following this closely... |
Another example is whether |
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388}
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388}
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388}
…of <details> is ignored, a=testonly Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388} -- wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560 wpt-pr: 12218
…of <details> is ignored, a=testonly Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388} -- wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560 wpt-pr: 12218
…of <details> is ignored, a=testonly Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgroganchromium.org> Reviewed-by: Christian Biesinger <cbiesingerchromium.org> Cr-Commit-Position: refs/heads/master{#589388} -- wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560 wpt-pr: 12218 UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
…of <details> is ignored, a=testonly Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgroganchromium.org> Reviewed-by: Christian Biesinger <cbiesingerchromium.org> Cr-Commit-Position: refs/heads/master{#589388} -- wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560 wpt-pr: 12218 UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
…of <details> is ignored, a=testonly Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in whatwg/html#3686 This scenario is discussed at the end of whatwg/html#603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: w3c/csswg-drafts#2084 whatwg/html#1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgroganchromium.org> Reviewed-by: Christian Biesinger <cbiesingerchromium.org> Cr-Commit-Position: refs/heads/master{#589388} -- wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560 wpt-pr: 12218 UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
The
<summary>
tag could have variousdisplay
style. I wonder what to do to when it has style other than the defaultdisplay: list-item
. For example, when<summery>
hasdisplay: table-cell
. Do we need to move the element to the front and render it as the "summary"? Doesdisplay: table-cell
on summary make sense?One possible idea is to define the concept of "rendered summary" like "rendered legend", and we only render the first summary tag as the "rendered summary" only if it satisfies certain conditions. Other
display
style as if it isAnother one is always render the first child summary element like spec says now, but we restrict the possible
display
value to a subset likenone
,block
,list-item
and ignore other values.Any other ideas? @bzbarsky @annevk
The text was updated successfully, but these errors were encountered: