Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to render <summary> when it has display style like "table-cell"? #1839

Open
aethanyc opened this issue Sep 29, 2016 · 3 comments
Open

How to render <summary> when it has display style like "table-cell"? #1839

aethanyc opened this issue Sep 29, 2016 · 3 comments

Comments

@aethanyc
Copy link

aethanyc commented Sep 29, 2016

The <summary> tag could have various display style. I wonder what to do to when it has style other than the default display: list-item. For example, when <summery> has display: table-cell. Do we need to move the element to the front and render it as the "summary"? Does display: table-cell on summary make sense?

One possible idea is to define the concept of "rendered summary" like "rendered legend", and we only render the first summary tag as the "rendered summary" only if it satisfies certain conditions. Other

element would be rendered according to its display style as if it is
. The downside of this is that it might make the rendering complex because we will need to keep searching for the first summary element that satisfy the conditions, and the first child summary element might not be the rendered summary.

Another one is always render the first child summary element like spec says now, but we restrict the possible display value to a subset like none, block, list-item and ignore other values.

Any other ideas? @bzbarsky @annevk

@zcorpan
Copy link
Member

zcorpan commented Sep 30, 2016

The spec says

The details element is expected to render as a block box. The element's shadow tree is expected to take the element's first child summary element, if any, and place it in a first block box container, and then take the element's remaining descendants, if any, and place them in a second block box container.

So isn't it well defined what should happen for different 'display' values of the summary, since CSS defines behavior for any 'display' value inside a block box? (In the case of 'table-cell', it's wrapped in an anonymous table and table row.)

@bzbarsky
Copy link
Contributor

I thought there was agreement that the current spec language is not the behavior people actually want? But I admit I haven't been following this closely...

@aethanyc
Copy link
Author

aethanyc commented Oct 5, 2016

Another example is whether <summary style="display: contents"> is considered valid since is does not produce a box itself when rendering. It's questionable to move such a element child to the front.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Aug 3, 2018
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 6, 2018
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
aarongable pushed a commit to chromium/chromium that referenced this issue Sep 7, 2018
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 7, 2018
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 7, 2018
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 12, 2018
…of <details> is ignored, a=testonly

Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}

--

wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560
wpt-pr: 12218
jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Sep 12, 2018
…of <details> is ignored, a=testonly

Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589388}

--

wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560
wpt-pr: 12218
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…of <details> is ignored, a=testonly

Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgroganchromium.org>
Reviewed-by: Christian Biesinger <cbiesingerchromium.org>
Cr-Commit-Position: refs/heads/master{#589388}

--

wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560
wpt-pr: 12218

UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…of <details> is ignored, a=testonly

Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgroganchromium.org>
Reviewed-by: Christian Biesinger <cbiesingerchromium.org>
Cr-Commit-Position: refs/heads/master{#589388}

--

wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560
wpt-pr: 12218

UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…of <details> is ignored, a=testonly

Automatic update from web-platform-testsAdd test asserting the display property of <details> is ignored

Chrome, Safari, and Firefox pass. Edge hasn't implemented yet.

The test still holds for the proposed new spec text in
whatwg/html#3686

This scenario is discussed at the end of
whatwg/html#603 but the conclusion drawn
appears (to me) to be opposite what Chrome, Safari, and Firefox do.

Related other issues:
w3c/csswg-drafts#2084
whatwg/html#1839

Bug: 635282
Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2
Reviewed-on: https://chromium-review.googlesource.com/1153651
Commit-Queue: David Grogan <dgroganchromium.org>
Reviewed-by: Christian Biesinger <cbiesingerchromium.org>
Cr-Commit-Position: refs/heads/master{#589388}

--

wpt-commits: 9d5d9aa80785d9726ed0a5eaab1a8d144fd4b560
wpt-pr: 12218

UltraBlame original commit: 3e84907d855160d165c2989d9cdd7f53f9ab16d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants