-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summary element definition does not reflect implementations #2246
Comments
Yeah, we should probably define activation behavior for it. |
Fixes #2246. This also fixes the value that the open attribute is set to to be the empty string, instead of "open", matching existing implementations.
suggest the following also need to be updated:
https://html.spec.whatwg.org/multipage/forms.html#the-summary-element and https://html.spec.whatwg.org/multipage/forms.html#the-details-element |
@stevefaulkner why would those be updated? They're unrelated to the activation behavior. |
@domenic summary is a focusable interactive element? as per https://html.spec.whatwg.org/multipage/dom.html#interactive-content-2 |
Sure, in some browsers it does have the tabindex focus flag set. Why does that impact the categories or content model? |
because its interactive content "Interactive content is content that is specifically intended for user interaction." |
I see, we need to update the definition of the interactive content category to include it (when it meets the requirements) |
Also |
Ah yeah OK, so summary should not be; details covers that case. This is especially important, e.g., for details elements without a summary. (Remember interactive content is a content category for authoring requirements, separate from the activation behavior which defines the processing model.) Another good example of this is how video (with controls) is interactive content, even though the element itself is not interactive, the controls inside of it are. Similarly details is interactive content, even though actually it's the UA-generated widget whose contents are drawn from the summary element that are interactive, not the whole details. |
ok |
Hmm. I think there's a piece missing in the content models. The |
Fixes #2246. This also fixes the value that the open attribute is set to to be the empty string, instead of "open", matching existing implementations. Tests at web-platform-tests/wpt#4539 show that both implementers of <details> follow these same semantics, despite there having been no spec previously. The only exception is that Blink included a being-rendered check, but that was removed; see https://bugs.chromium.org/p/chromium/issues/detail?id=681711. There's still some discussion ongoing as to whether we should change the content models to disallow interactive descendants of <summary> elements, happening in #2272.
Fixes whatwg#2246. This also fixes the value that the open attribute is set to to be the empty string, instead of "open", matching existing implementations. Tests at web-platform-tests/wpt#4539 show that both implementers of <details> follow these same semantics, despite there having been no spec previously. The only exception is that Blink included a being-rendered check, but that was removed; see https://bugs.chromium.org/p/chromium/issues/detail?id=681711. There's still some discussion ongoing as to whether we should change the content models to disallow interactive descendants of <summary> elements, happening in whatwg#2272.
In all implementations: blink/webkit/firefox the
summary
element is an interactive element. It receives focus and is operated to open/close the details element. It is also exposed as a control via acc APIs in all implementations.Suggest the spec should be updated to reflect this.
The text was updated successfully, but these errors were encountered: