Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update [report an exception] to work with globals which aren't EventTargets. #2611

Closed
bfgeek opened this issue May 1, 2017 · 1 comment · Fixed by #6056
Closed

Update [report an exception] to work with globals which aren't EventTargets. #2611

bfgeek opened this issue May 1, 2017 · 1 comment · Fixed by #6056
Assignees
@domenic
Labels
integration

Comments

@bfgeek
Copy link
Member

bfgeek commented May 1, 2017

The base WorkletGlobalScope[1] doesn't inherit from an EventTarget, and may cause errors to be thrown during fetching scripts.

[1] https://drafts.css-houdini.org/worklets/#workletglobalscope
@domenic domenic self-assigned this May 1, 2017
@annevk
Copy link
Member

annevk commented May 2, 2017

@bfgeek since we need EventTarget for audio worklets, can't we just use it here too?

@annevk annevk mentioned this issue Jul 28, 2017
Open
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 5, 2019
@karlt
Bug 1558128 report errors from worklet scripts to console r=baku
289744e 
There is no ErrorEvent dispatched to WorkletGlobalScope.
See also whatwg/html#2611

Differential Revision: https://phabricator.services.mozilla.com/D44600

--HG--
extra : moz-landing-system : lando
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Sep 6, 2019
@karlt
Bug 1558128 report errors from worklet scripts to console r=baku
552c0e5 
There is no ErrorEvent dispatched to WorkletGlobalScope.
See also whatwg/html#2611

Differential Revision: https://phabricator.services.mozilla.com/D44600
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1558128 report errors from worklet scripts to console r=baku
5e84752 
There is no ErrorEvent dispatched to WorkletGlobalScope.
See also whatwg/html#2611

Differential Revision: https://phabricator.services.mozilla.com/D44600

UltraBlame original commit: 1069ae045160d78eb4d38aeaecfe8e66f6faeed7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1558128 report errors from worklet scripts to console r=baku
c79d170 
There is no ErrorEvent dispatched to WorkletGlobalScope.
See also whatwg/html#2611

Differential Revision: https://phabricator.services.mozilla.com/D44600

UltraBlame original commit: 1069ae045160d78eb4d38aeaecfe8e66f6faeed7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
@marco-c
Bug 1558128 report errors from worklet scripts to console r=baku
316cc8a 
There is no ErrorEvent dispatched to WorkletGlobalScope.
See also whatwg/html#2611

Differential Revision: https://phabricator.services.mozilla.com/D44600

UltraBlame original commit: 1069ae045160d78eb4d38aeaecfe8e66f6faeed7
domenic added a commit that referenced this issue Oct 12, 2020
@domenic
Move worklets into to the HTML Standard
03df458 
Closes w3c/css-houdini-drafts#1000. Closes
#2611.
domenic added a commit that referenced this issue Oct 12, 2020
@domenic
Move worklets into to the HTML Standard
eea805f 
Closes w3c/css-houdini-drafts#1000. Closes
#2611.
domenic added a commit that referenced this issue Oct 12, 2020
@domenic
Move worklets into to the HTML Standard
1a334de 
Closes w3c/css-houdini-drafts#1000. Closes
#2611.
@domenic domenic mentioned this issue Oct 12, 2020
Merged
domenic added a commit that referenced this issue Oct 16, 2020
@domenic
Move worklets into the HTML Standard
25c78e4 
Closes w3c/css-houdini-drafts#1000.

This provides a baseline by porting over all the existing text from
https://drafts.css-houdini.org/worklets/, modernizing and restructuring
it along the way. It does not yet fix many of the open logged issues
(although it does fix some; see below).

Notable changes from that document:

* Rearranged sections to better match workers, and my sense of flow.

* Moved worklet script fetching to be siblings with all the other script
  fetching algorithms.

* Improved clarity and guidance on what specifications that define
  worklets should do, including fleshing out the fake worklet example.

* Changed "create a WorkletGlobalScope", which took one set of
  arguments, to "create a worklet global scope", which just takes a
  Worklet instance. This appears to match better how the algorithm is
  used, e.g. in
  https://drafts.css-houdini.org/css-paint-api/#draw-a-paint-image step
  10.

* Updated "report an error" to bail out for non-EventTarget globals,
  like WorkletGlobalScope. Closes #2611.

* Updated worklets to only be exposed in secure contexts. Closes
  w3c/css-houdini-drafts#505.

* Makes the lifetime of creating and terminating WorkletGlobalScopes
  more explicit. Closes
  w3c/css-houdini-drafts#224. Closes
  w3c/css-houdini-drafts#389.

* Explicitly start and stop the event loop for a given
  WorkletGlobalScope upon creation/termination. Closes
  w3c/css-houdini-drafts#843.
  Closes w3c/css-houdini-drafts#318 for real.

* Fixes creation of new worklet global scopes to only run the top-level
  module scripts added via addModule(), which will automatically run
  their dependencies. Previously it would run all module scripts loaded
  into the worklet, so dependencies would be run in the order they were
  fetched, not as part of the top-down module evaluation process. Closes
  w3c/css-houdini-drafts#264.
@annevk annevk mentioned this issue Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
integration
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move worklets into the HTML Standard whatwg/html
3 participants
@domenic @bfgeek @annevk