Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <slot>'s UA style, "display: contents", be !important #3143

Closed
hayatoito opened this issue Oct 20, 2017 · 5 comments
Closed

Make <slot>'s UA style, "display: contents", be !important #3143

hayatoito opened this issue Oct 20, 2017 · 5 comments

Comments

@hayatoito
Copy link
Member

hayatoito commented Oct 20, 2017

Originally, discussed at https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5s1nbytTL68/Kx-dtQ34BAAJ.

It would be better to make <slot>'s UA style, "display: contents", be !important to prevent accidental overwrite by author rules.

slot {
  display: contents;
}

is defined here: https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3

@domenic
Copy link
Member

domenic commented Oct 20, 2017

@rniwa, what do you think? You were the original display: contents proponent, if I recall.

@rniwa
Copy link

rniwa commented Oct 20, 2017

I don't think we should do this. Otherwise author won't be able to override display of a slot. Being able to stylize slot as a different display type servers valid use cases.

@hayatoito
Copy link
Member Author

hayatoito commented Oct 20, 2017

I see. I don't have a strong opinion on this.

@rniwa, I don't have any data yet, but if Blink has a trouble in making slots participate in a flat tree because of this rule, are you okay to make this rule be !important?

I hope that Blink wouldn't have such a trouble, but just in case.

@rniwa
Copy link

rniwa commented Oct 20, 2017

No. We don't want to make this !important. It's okay if some engines had bugs.

@hayatoito
Copy link
Member Author

hayatoito commented Oct 20, 2017

Okay. Let's close this issue.

I might re-open this issue if Blink encounters a trouble because interoperability is much more important than use cases which we have not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants