Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta name comparison should be explicitly ASCII case-insensitive #3332

Closed
domenic opened this issue Jan 7, 2018 · 2 comments
Closed

meta name comparison should be explicitly ASCII case-insensitive #3332

domenic opened this issue Jan 7, 2018 · 2 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@domenic
Copy link
Member

domenic commented Jan 7, 2018

https://html.spec.whatwg.org/multipage/semantics.html#standard-metadata-names

It says at the top

Names are case-insensitive, and must be compared in an ASCII case-insensitive manner.

but later in some processing models it says

  • has its name attribute set to the value application-name
  • whose name attribute's value is keywords
  • The element has a name attribute, whose value is referrer
  • The element has a name attribute, whose value is theme-color

These three instances should be changed to "value is an ASCII case-insensitive match for X", with "ASCII case-insensitive" appropriately linked. Otherwise, they currently indicate something contradictory to the opening paragraph.

@domenic domenic added clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project labels Jan 7, 2018
@annevk
Copy link
Member

annevk commented Jan 8, 2018

(I think it would be even better if we had some kind of name concept indirection that either returned an ASCII lowercased string or null if there's no name attribute.)

@domenic
Copy link
Member Author

domenic commented Jan 8, 2018

I mean I was thinking of going further and abstracting out the whole predicate of step 1 of https://html.spec.whatwg.org/multipage/semantics.html#meta-referrer (with the "in head" check optional) and trying to use it more uniformly throughout the section. E.g. keywords and application-name use a loose variant of that, whereas theme-color uses something similar to that... all kind of a mess.

But for now, just this quick fix will suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

2 participants