Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing table sorting model #345

Closed
smaug---- opened this issue Nov 16, 2015 · 8 comments
Closed

Consider removing table sorting model #345

smaug---- opened this issue Nov 16, 2015 · 8 comments
Labels
removal/deprecation Removing or deprecating a feature

Comments

@smaug----
Copy link

https://html.spec.whatwg.org/multipage/tables.html#table-sorting-model is complicated and at least Gecko nor Blink seem to have support for it.
I don't see any relevant properties in http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTableElement.idl either.

There are existing script libraries doing the sorting and scripts can be always more flexible deciding which way to sort.

@rniwa
Copy link

rniwa commented Nov 17, 2015

I don't think anyone is working on this feature in WebKit. @hober

@annevk
Copy link
Member

annevk commented Nov 17, 2015

Yeah, I guess we should remove it. It is somewhat unfortunate though since it's a great feature.

@annevk annevk added removal/deprecation Removing or deprecating a feature good first issue Ideal for someone new to a WHATWG standard or software project labels Nov 17, 2015
@foolip
Copy link
Member

foolip commented Nov 17, 2015

👍 to remove

@hober
Copy link
Contributor

hober commented Nov 17, 2015

Yeah. Sadface, but it's a good candidate for removal.

@sideshowbarker
Copy link
Contributor

I don’t object to removing it but would have been happier to see a concrete proposal for simplifying it (though I’m not volunteering to write one). That said, it seems somewhat clear at this point that we’re not likely to ever get implementor support for this regardless of how it’s specced. I hope that’s not a failure on our part to align with the Priority of Constituencies in the way we should be (because I think this is something that we bring real benefits relatively directly to end users), but I guess users have been managing for all these years to get by without the Web having it, so it’s not like dropping it from the spec would be regressing anything. Still, sad.

@Ritsyy
Copy link
Contributor

Ritsyy commented Dec 23, 2015

As discussed above because it is not supported anymore. The Table sorting model in https://html.spec.whatwg.org/multipage/tables.html#table-sorting-model and one of it's example below it needs to be removed. There is one more example related to it https://html.spec.whatwg.org/multipage/semantics.html#dom-data-value this needs to be removed too.

@domenic
Copy link
Member

domenic commented Dec 23, 2015

Hmm. This might not be a good first bug. The table sorting model has a lot of parts that need to be removed, not just that section. For example, you'd probably need to merge HTMLTableHeaderCellElement and HTMLTableDataCellElement back into HTMLTableCellElement (since that's what's implemented everywhere), and remove everything to do with the "scope" property, and remove related examples that reference "table sorting model", and probably more I am forgetting...

Relevant commits that added stuff that should probably be removed:

plus probably more.

I don't think this is a good first bug... You're welcome to work on it still though!

@domenic domenic removed the good first issue Ideal for someone new to a WHATWG standard or software project label Dec 23, 2015
@Ritsyy
Copy link
Contributor

Ritsyy commented Dec 23, 2015

Oh ok i'll see into it, and try to find other related examples too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature
Development

No branches or pull requests

8 participants