Consider removing table sorting model #345

Closed
smaug---- opened this Issue Nov 16, 2015 · 8 comments

Comments

8 participants
@smaug----
Collaborator

smaug---- commented Nov 16, 2015

https://html.spec.whatwg.org/multipage/tables.html#table-sorting-model is complicated and at least Gecko nor Blink seem to have support for it.
I don't see any relevant properties in http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLTableElement.idl either.

There are existing script libraries doing the sorting and scripts can be always more flexible deciding which way to sort.

@rniwa

This comment has been minimized.

Show comment
Hide comment
@rniwa

rniwa Nov 17, 2015

Collaborator

I don't think anyone is working on this feature in WebKit. @hober

Collaborator

rniwa commented Nov 17, 2015

I don't think anyone is working on this feature in WebKit. @hober

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Nov 17, 2015

Member

Yeah, I guess we should remove it. It is somewhat unfortunate though since it's a great feature.

Member

annevk commented Nov 17, 2015

Yeah, I guess we should remove it. It is somewhat unfortunate though since it's a great feature.

@foolip

This comment has been minimized.

Show comment
Hide comment
@foolip

foolip Nov 17, 2015

Member

👍 to remove

Member

foolip commented Nov 17, 2015

👍 to remove

@hober

This comment has been minimized.

Show comment
Hide comment
@hober

hober Nov 17, 2015

Collaborator

Yeah. Sadface, but it's a good candidate for removal.

Collaborator

hober commented Nov 17, 2015

Yeah. Sadface, but it's a good candidate for removal.

@sideshowbarker

This comment has been minimized.

Show comment
Hide comment
@sideshowbarker

sideshowbarker Nov 19, 2015

Member

I don’t object to removing it but would have been happier to see a concrete proposal for simplifying it (though I’m not volunteering to write one). That said, it seems somewhat clear at this point that we’re not likely to ever get implementor support for this regardless of how it’s specced. I hope that’s not a failure on our part to align with the Priority of Constituencies in the way we should be (because I think this is something that we bring real benefits relatively directly to end users), but I guess users have been managing for all these years to get by without the Web having it, so it’s not like dropping it from the spec would be regressing anything. Still, sad.

Member

sideshowbarker commented Nov 19, 2015

I don’t object to removing it but would have been happier to see a concrete proposal for simplifying it (though I’m not volunteering to write one). That said, it seems somewhat clear at this point that we’re not likely to ever get implementor support for this regardless of how it’s specced. I hope that’s not a failure on our part to align with the Priority of Constituencies in the way we should be (because I think this is something that we bring real benefits relatively directly to end users), but I guess users have been managing for all these years to get by without the Web having it, so it’s not like dropping it from the spec would be regressing anything. Still, sad.

@Ritsyy

This comment has been minimized.

Show comment
Hide comment
@Ritsyy

Ritsyy Dec 23, 2015

Collaborator

As discussed above because it is not supported anymore. The Table sorting model in https://html.spec.whatwg.org/multipage/tables.html#table-sorting-model and one of it's example below it needs to be removed. There is one more example related to it https://html.spec.whatwg.org/multipage/semantics.html#dom-data-value this needs to be removed too.

Collaborator

Ritsyy commented Dec 23, 2015

As discussed above because it is not supported anymore. The Table sorting model in https://html.spec.whatwg.org/multipage/tables.html#table-sorting-model and one of it's example below it needs to be removed. There is one more example related to it https://html.spec.whatwg.org/multipage/semantics.html#dom-data-value this needs to be removed too.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Dec 23, 2015

Member

Hmm. This might not be a good first bug. The table sorting model has a lot of parts that need to be removed, not just that section. For example, you'd probably need to merge HTMLTableHeaderCellElement and HTMLTableDataCellElement back into HTMLTableCellElement (since that's what's implemented everywhere), and remove everything to do with the "scope" property, and remove related examples that reference "table sorting model", and probably more I am forgetting...

Relevant commits that added stuff that should probably be removed:

plus probably more.

I don't think this is a good first bug... You're welcome to work on it still though!

Member

domenic commented Dec 23, 2015

Hmm. This might not be a good first bug. The table sorting model has a lot of parts that need to be removed, not just that section. For example, you'd probably need to merge HTMLTableHeaderCellElement and HTMLTableDataCellElement back into HTMLTableCellElement (since that's what's implemented everywhere), and remove everything to do with the "scope" property, and remove related examples that reference "table sorting model", and probably more I am forgetting...

Relevant commits that added stuff that should probably be removed:

plus probably more.

I don't think this is a good first bug... You're welcome to work on it still though!

@Ritsyy

This comment has been minimized.

Show comment
Hide comment
@Ritsyy

Ritsyy Dec 23, 2015

Collaborator

Oh ok i'll see into it, and try to find other related examples too.

Collaborator

Ritsyy commented Dec 23, 2015

Oh ok i'll see into it, and try to find other related examples too.

@foolip foolip closed this in 59b7e24 Jan 28, 2016

foolip added a commit to whatwg/html-build that referenced this issue Jan 28, 2016

@foolip foolip referenced this issue in whatwg/html-build Jan 28, 2016

Merged

Drop suppresson of missing <dfn> error #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment