Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop execution context off the stack after InitializeHostDefinedRealm #3784

Closed
TimothyGu opened this issue Jun 29, 2018 · 0 comments
Closed

Comments

@TimothyGu
Copy link
Member

TimothyGu commented Jun 29, 2018

InitializeHostDefinedRealm is defined by ECMAScript to push the newly created execution context to the stack. This is especially visible after #3314. However, in the four callsites of InitializeHostDefinedRealm in the spec, none of them actually pop the new execution context off the stack after they are done, which can lead to many issues. We probably want to create an algorithm that creates the realm and execution context and pops it off the stack for us, and use that algorithm whenever we call InitializeHostDefinedRealm.

One question is if we want to use clean up after running script instead of manual popping. Probably not though, since we don't want most algorithms that create a new realm to run microtasks as a side effect.

/cc @domenic

TimothyGu added a commit to TimothyGu/html that referenced this issue Jul 22, 2018
TimothyGu added a commit to TimothyGu/html that referenced this issue Jul 23, 2018
TimothyGu added a commit to TimothyGu/html that referenced this issue Jul 23, 2018
domenic pushed a commit that referenced this issue Jul 28, 2018
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant