Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the document's address doesn't seem to be correct #3953

Closed
TimothyGu opened this issue Aug 21, 2018 · 1 comment
Closed

Setting the document's address doesn't seem to be correct #3953

TimothyGu opened this issue Aug 21, 2018 · 1 comment
Labels
topic: document lifecycle

Comments

@TimothyGu
Copy link
Member

https://html.spec.whatwg.org/#set-the-document's-address has:

any Document created by [initialize the Document object] must have its URL set to the URL that was originally to be fetched, ignoring any other data that was used to obtain the resource.

This doesn't sound correct, with respect to request vs. response URLs.
@TimothyGu TimothyGu mentioned this issue Aug 21, 2018
Merged
@annevk
Copy link
Member

annevk commented Aug 22, 2018

Yeah, ideally we define document creation more imperatively, but it's a lot of work refactoring all the intertwingledness of the existing text.

jyasskin added a commit to jyasskin/html that referenced this issue Nov 26, 2018
@jyasskin
Specify a new document's URL
6cec696 
The "URL that was originally to be fetched" isn't clear about which URL
that actually is.

The choices here are:

* The request's URL: The original URL before any redirects.
* The request's current URL: The final URL after any redirects, and
  treating a Service Worker's response as from that URL.
* The response's URL: Either the final URL after any redirects, or, if a
  Service Worker intercepted the fetch and returned a response from a
  different URL, that different URL.

Fixes whatwg#3953.
@jyasskin jyasskin mentioned this issue Nov 26, 2018
Merged
jyasskin added a commit to jyasskin/html that referenced this issue Dec 12, 2018
@jyasskin
Specify a new document's URL
b0d2b06 
The "URL that was originally to be fetched" isn't clear about which URL
that actually is.

The choices here are:

* The request's URL: The original URL before any redirects.
* The request's current URL: The final URL after any redirects, and
  treating a Service Worker's response as from that URL.
* The response's URL: Either the final URL after any redirects, or, if a
  Service Worker intercepted the fetch and returned a response from a
  different URL, that different URL.

Fixes whatwg#3953.
domenic pushed a commit that referenced this issue Dec 18, 2018
@jyasskin @domenic
Specify a navigated-to new document's URL
f2c7ea3 
The "URL that was originally to be fetched" isn't clear about which URL
that actually was. This makes it clear that we use the request's current
URL when available, or the response's URL when not.

For javascript: URLs, this fixes them to match 2/3 browser behavior.
6440cca regressed the algorithm by
deleting the actual usage site of the address variable. This change
reintroduces the use of address, although in a simpler way, by appending
address to the request's URL list, instead of using the "override URL"
concept which was removed.

Fixes #3953.

Closes #1565 by preserving the special case; discussions there and in
https://bugzilla.mozilla.org/show_bug.cgi?id=1281375#c7 indicate that
the special case is more web-compatible.

Tests:

* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/browsers/history/the-location-interface/location_hash.html#L24
* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm
* web-platform-tests/wpt#14288
* web-platform-tests/wpt#14316
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@jyasskin @mustaqahmed
Specify a navigated-to new document's URL
ca2b58c 
The "URL that was originally to be fetched" isn't clear about which URL
that actually was. This makes it clear that we use the request's current
URL when available, or the response's URL when not.

For javascript: URLs, this fixes them to match 2/3 browser behavior.
6440cca regressed the algorithm by
deleting the actual usage site of the address variable. This change
reintroduces the use of address, although in a simpler way, by appending
address to the request's URL list, instead of using the "override URL"
concept which was removed.

Fixes whatwg#3953.

Closes whatwg#1565 by preserving the special case; discussions there and in
https://bugzilla.mozilla.org/show_bug.cgi?id=1281375#c7 indicate that
the special case is more web-compatible.

Tests:

* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/browsers/history/the-location-interface/location_hash.html#L24
* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm
* web-platform-tests/wpt#14288
* web-platform-tests/wpt#14316
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@jyasskin @mustaqahmed
Specify a navigated-to new document's URL
0920e22 
The "URL that was originally to be fetched" isn't clear about which URL
that actually was. This makes it clear that we use the request's current
URL when available, or the response's URL when not.

For javascript: URLs, this fixes them to match 2/3 browser behavior.
6440cca regressed the algorithm by
deleting the actual usage site of the address variable. This change
reintroduces the use of address, although in a simpler way, by appending
address to the request's URL list, instead of using the "override URL"
concept which was removed.

Fixes whatwg#3953.

Closes whatwg#1565 by preserving the special case; discussions there and in
https://bugzilla.mozilla.org/show_bug.cgi?id=1281375#c7 indicate that
the special case is more web-compatible.

Tests:

* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/browsers/history/the-location-interface/location_hash.html#L24
* https://github.com/web-platform-tests/wpt/blob/7ed525acfb4133c1177fdb1ff8477e2a6469e6b4/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm
* web-platform-tests/wpt#14288
* web-platform-tests/wpt#14316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: document lifecycle
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @TimothyGu @annevk