Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextMetrics advances aren't specified to reflect layout advances or paint advances #4034

Open
litherum opened this issue Sep 14, 2018 · 1 comment
Open

TextMetrics advances aren't specified to reflect layout advances or paint advances #4034

litherum opened this issue Sep 14, 2018 · 1 comment
Labels
topic: canvas

Comments

@litherum
Copy link

https://html.spec.whatwg.org/multipage/canvas.html#dom-textmetrics-advances

In WebKit, we have a distinction between layout advances (used for layout, and determining the bounds of each character when selecting using the mouse) and paint advances (delivered to the graphics subsystem when painting).

Which should we return in this API?
@annevk
Copy link
Member

annevk commented Sep 14, 2018

cc @whatwg/canvas

domenic added a commit that referenced this issue Sep 14, 2018
@domenic
Revert "Add advances to TextMetrics and change baselines API"
879c5a1 
This reverts commit 7711a1f. As
discussed in #3995, these changes were made prematurely without
appropriate implementer signoff. Since then, a plethora of issues around
the changes here have been opened up (e.g. #3994, #4023, #4030, #4033,
#4034). We revert these changes until a more complete and agreed-upon
specification can replace them.

Closes #3995.
This was referenced Sep 14, 2018
Merged
Closed
domenic added a commit that referenced this issue Sep 17, 2018
@domenic
Revert "Add advances to TextMetrics and change baselines API"
31c0db3 
This reverts commit 7711a1f. As
discussed in #3995, these changes were made prematurely without
appropriate implementer sign-off. Since then, a plethora of issues
around the changes here have been opened up (e.g. #3994, #4023, #4026,
#4030, #4033, #4034). We revert these changes until a more complete and
agreed-upon specification can replace them.

Closes #3995.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@domenic @mustaqahmed
Revert "Add advances to TextMetrics and change baselines API"
973b4cb 
This reverts commit 7711a1f. As
discussed in whatwg#3995, these changes were made prematurely without
appropriate implementer sign-off. Since then, a plethora of issues
around the changes here have been opened up (e.g. whatwg#3994, whatwg#4023, whatwg#4026,
whatwg#4030, whatwg#4033, whatwg#4034). We revert these changes until a more complete and
agreed-upon specification can replace them.

Closes whatwg#3995.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@domenic @mustaqahmed
Revert "Add advances to TextMetrics and change baselines API"
066a726 
This reverts commit 7711a1f. As
discussed in whatwg#3995, these changes were made prematurely without
appropriate implementer sign-off. Since then, a plethora of issues
around the changes here have been opened up (e.g. whatwg#3994, whatwg#4023, whatwg#4026,
whatwg#4030, whatwg#4033, whatwg#4034). We revert these changes until a more complete and
agreed-upon specification can replace them.

Closes whatwg#3995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: canvas
Milestone
No milestone
Development

No branches or pull requests
2 participants
@litherum @annevk