New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMetrics advances aren't specified to reflect layout advances or paint advances #4034

Open
litherum opened this Issue Sep 14, 2018 · 1 comment

Comments

2 participants
@litherum

litherum commented Sep 14, 2018

https://html.spec.whatwg.org/multipage/canvas.html#dom-textmetrics-advances

In WebKit, we have a distinction between layout advances (used for layout, and determining the bounds of each character when selecting using the mouse) and paint advances (delivered to the graphics subsystem when painting).

Which should we return in this API?

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk
Member

annevk commented Sep 14, 2018

domenic added a commit that referenced this issue Sep 14, 2018

Revert "Add advances to TextMetrics and change baselines API"
This reverts commit 7711a1f. As
discussed in #3995, these changes were made prematurely without
appropriate implementer signoff. Since then, a plethora of issues around
the changes here have been opened up (e.g. #3994, #4023, #4030, #4033,
#4034). We revert these changes until a more complete and agreed-upon
specification can replace them.

Closes #3995.

domenic added a commit that referenced this issue Sep 17, 2018

Revert "Add advances to TextMetrics and change baselines API"
This reverts commit 7711a1f. As
discussed in #3995, these changes were made prematurely without
appropriate implementer sign-off. Since then, a plethora of issues
around the changes here have been opened up (e.g. #3994, #4023, #4026,
#4030, #4033, #4034). We revert these changes until a more complete and
agreed-upon specification can replace them.

Closes #3995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment