Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments ordering in Report long tasks for “user agent does not execute this loop” #4114

Closed
triple-underscore opened this issue Oct 23, 2018 · 1 comment

Comments

@triple-underscore
Copy link
Contributor

§8.1.4.2( https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model )
related to: #4059 by @npm1

Report the duration of time during which the user agent does not execute this loop by performing the following steps:
...
If event loop end is set, then let top-level browsing contexts be the set of all top-level browsing contexts of all Document objects associated with the event loop. Report long tasks, passing in event loop begin, event loop end, "browser", and top-level browsing contexts.

I think the order of "event loop begin", "event loop end" should be swapped,
since this "event loop end", the time previous iteration of the loop has ended, is earlier than "event loop begin"

@npm1
Copy link
Contributor

npm1 commented Oct 23, 2018

That's correct, thanks for catching this! Hmm this is a very simple PR but I currently only have access to a Chromebook which means I can't easily create a PR. Feel free to send a PR for this, otherwise I'll fix it in about 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants