Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDL for HTMLScriptElement needs to escape "async" #4834

Closed
domenic opened this issue Aug 9, 2019 · 4 comments
Closed

IDL for HTMLScriptElement needs to escape "async" #4834

domenic opened this issue Aug 9, 2019 · 4 comments
Assignees
@domenic

Comments

@domenic
Copy link
Member

domenic commented Aug 9, 2019

It is now a Web IDL keyword. #4833 tracked how this broke our build, but that got fixed. Now we just need to update our IDL to be valid.
@domenic domenic self-assigned this Aug 9, 2019
@annevk
Copy link
Member

annevk commented Aug 12, 2019

See whatwg/webidl#769 so maybe @tabatkins should update their IDL parser?

@domenic
Copy link
Member Author

domenic commented Aug 12, 2019

Yeah, or rather, we should land the heycam/webidl change -> plinss/widlparser change -> tabatkins/highlighter change -> whatwg/html-build change -> rebuild the HTML Standard on Travis. Dependency fun times :)

@tabatkins
Copy link
Contributor

At least it's fast once the update lands in widlparser. ^_^

@domenic
Copy link
Member Author

domenic commented Sep 18, 2019

Fixed in IDL!

@domenic domenic closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @tabatkins @annevk