Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated removal from queue in the Event Processing Model #4888

Closed
mfreed7 opened this issue Sep 6, 2019 · 2 comments · Fixed by #4897
Closed

Duplicated removal from queue in the Event Processing Model #4888

mfreed7 opened this issue Sep 6, 2019 · 2 comments · Fixed by #4897
Labels
topic: event loop

Comments

@mfreed7
Copy link
Contributor

mfreed7 commented Sep 6, 2019

I could definitely be missing something, but in the Event Processing Model, step 2 says:

  1. Let oldestTask be the first runnable task in taskQueue, and remove it from taskQueue.

and step 7 says:

  1. Remove oldestTask from its task queue.

There aren't any early-outs between 2 and 7, so my guess is that step 7 can just be deleted?
@domenic
Copy link
Member

domenic commented Sep 9, 2019

Thank you! This was introduced accidentally in https://github.com/whatwg/html/pull/4465/files. I will fix.

domenic added a commit that referenced this issue Sep 9, 2019
@domenic
Editorial: remove now-redundant removal of event loop task
6e233d2 
Closes #4888. f4e2907 refactored these
steps to remove the task as part of step 2, so step 7 is no longer
needed.
@domenic domenic mentioned this issue Sep 9, 2019
Merged
@mfreed7
Copy link
Contributor Author

mfreed7 commented Sep 12, 2019

Thanks!

domenic added a commit that referenced this issue Sep 13, 2019
@domenic
Editorial: remove now-redundant removal of event loop task
edcf2ef 
Closes #4888. f4e2907 refactored these
steps to remove the task as part of step 2, so step 7 is no longer
needed.
zcorpan pushed a commit that referenced this issue Nov 6, 2019
@domenic @zcorpan
Editorial: remove now-redundant removal of event loop task
5d9cf47 
Closes #4888. f4e2907 refactored these
steps to remove the task as part of step 2, so step 7 is no longer
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: event loop
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: remove now-redundant removal of event loop task whatwg/html
2 participants
@domenic @mfreed7