Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum used line-height of text-entry widget doesn't match implementations #5366

Closed
jfkthame opened this issue Mar 17, 2020 · 2 comments · Fixed by #5462
Closed

Minimum used line-height of text-entry widget doesn't match implementations #5366

jfkthame opened this issue Mar 17, 2020 · 2 comments · Fixed by #5462
Assignees
Labels
compat Standard is not web compatible or proprietary feature needs standardizing interop Implementations are not interoperable with each other topic: rendering

Comments

@jfkthame
Copy link

See https://html.spec.whatwg.org/#the-input-element-as-a-text-entry-widget:

Additionally, the 'line-height' property, if it has a computed value equivalent to a value that is less than 1.0, must have a used value of 1.0.

This rule is implemented by Gecko. But it appears that Webkit and Blink implement a different behavior, sites depend on that behavior, and as a result exhibit poor rendering in Gecko. See webcompat/web-bugs#47819 for an example.

I believe the Webkit/Blink result is preferable, and would like to modify Gecko to behave similarly.

Suggested new text to replace the sentence above:

Additionally, the used value of the 'line-height' property must be no smaller than the used value would be for 'line-height: normal'.

The idea here -- which Webkit and Blink appear to have adopted, despite what the spec currently says -- is that a used line-height of 1.0 is often too small and will result in unwanted clipping. This is what we see happening in Gecko. Given that clamping the minimum used line-height to normal rather than 1.0 appears to be web-compatible, I think we should simply change the spec (and Gecko) to reflect this.

@zcorpan
Copy link
Member

zcorpan commented Mar 17, 2020

This seems OK to me. I can change this and update test (or write a new test if there isn't one) probably next week.

@zcorpan zcorpan added compat Standard is not web compatible or proprietary feature needs standardizing interop Implementations are not interoperable with each other labels Mar 17, 2020
@zcorpan
Copy link
Member

zcorpan commented Feb 3, 2022

It has been a long week... but I've now written tests: web-platform-tests/wpt#32684

zcorpan added a commit that referenced this issue Feb 3, 2022
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat Standard is not web compatible or proprietary feature needs standardizing interop Implementations are not interoperable with each other topic: rendering
Development

Successfully merging a pull request may close this issue.

3 participants