Back-forward cache: Restoring focus #5878

rakina · 2020-08-31T02:07:44Z

It looks like focus works differently with bfcache in Safari, Firefox, and Chrome (thanks @tkent-google for noticing!)

If we navigate away from a page that has a focused element (e.g. submitting a text-input form), and we go back & restore it from bfcache (tester page) :

Safari: The focused element stays focused. The blur event is never fired. The focus event is only fired when the element initially gets focused.
Firefox: The focused element stays focused. The blur event is fired after pagehide (when navigating away) but before pageshow (when navigating back). The focus event is fired for the second time after pageshow.
Chrome: The focused element will lose focus on navigation away from the page (with the blur event fired before pagehide), and won't be focused again when we navigate back.

I think it would be ideal to restore the focused element when navigating back (like Safari & Firefox is currently doing), but I'm not sure whether it should be "focus is kept all this time" (so no blur event should be fired), or "focus was lost, but it's back again" (so we fire blur when navigating away, then fire focus when navigating back). Maybe the latter makes more sense as the entire document/page is no longer in focus after we navigate away from it.

The text was updated successfully, but these errors were encountered:

annevk · 2020-08-31T12:36:37Z

cc @cdumez @smaug----

domenic · 2020-08-31T23:12:52Z

I don't have much of substance to add, but I will say that this seems like a nice and small interop bug we could fix, compared to all the other scary bfcache business :). I hope we can get implementers to chime in.

I'm ambivalent myself between "focus is kept all the time" vs. "focus was lost, but it's back again". Maybe there are other similar features affected by bfcache which we could compare with?

domenic · 2020-11-22T19:31:38Z

Slightly related: WICG/portals#257

domenic · 2021-03-04T18:07:30Z

Various folks discussed this today in the triage meeting (#6371). The Mozilla and Google representatives present thought that between the Firefox and Safari behavior, the Safari was probably best. Although nobody felt too strongly, the idea of firing less events (and thus running less script) during page unload and load pushed us in that direction.

This might be what the spec already says; in particular I can't find anything that changes the focused area of the document, or runs focusing or unfocusing steps, on navigation (including bfcache navigation). However, it's possible the focus fixup rule applies upon navigations, if elements in navigated-away-from-documents are not "being rendered"... but I'm unsure. That might be worth investigating.

So, I think the action items here are:

Investigate "being rendered" for bfcached pages.
If elements in bfcache pages are "being rendered", i.e. if other parts of the spec ecosystem expect such elements to have CSS boxes etc., then:
1. Add a clarifying non-normative note to the definition of "being rendered" explaining that even inactive documents can have being-rendered elements.
If elements in bfcache pages are not "being rendered", then:
1. Add a clarifying non-normative note to the definition of "being rendered" explaining this.
2. Update the normative text of focus fixup rule to not run for when documents become inactive? Or some other normative fix, like changing the "being rendered" clause in the definition of focusable area.
Add a clarifying non-normative note to "focused area of the document" explaining that this does not change when a document becomes inactive or becomes active again.
Write web platform tests.
File browser bugs on Firefox and Chrome.
Fix browser bugs :)

Fixes whatwg#5878. Clarifies that the focused element stays the same/not reset when a document's "full active" state changed, and no events (focus/blur) are fired

rakina · 2021-05-19T13:25:22Z

Thanks @domenic! I looked into "being rendered" & "fully active" a while back, and found that "being rendered" is still true for non-fully active documents. I've sent a PR at #6696 to add notes as you suggested, and @hiroshige-g will upload a WPT PR soon!

rniwa · 2021-05-21T10:04:29Z

yeah, we generally don't want to fire events during moving pages in & out of the back-forward cache so sticking to Safari/WebKit's behavior is desirable here unless there are some web compatibility issues or use cases that can't be addressed with that approach.

Bug: 1107415, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

hiroshige-g · 2021-10-13T23:15:18Z

Uploaded WPT web-platform-tests/wpt#31084, confirming the behavior described at #5878 (comment) (passing on Safari, failing on Chromium/Firefox).

Bug: 1107415, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

Fixes #5878. Clarifies that the focused element stays the same and is not reset when a document's fully active state is changed, and no events (focus/blur) are fired. Also clarifies that fully active does not impact "being rendered" or viewport intersection.

Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

WestonThayer · 2021-11-30T20:46:17Z

Are there any issues tracking restoring focus for back/forward navigations to in-document fragments? Related: https://bugs.chromium.org/p/chromium/issues/detail?id=1275230

Fixes whatwg#5878. Clarifies that the focused element stays the same and is not reset when a document's fully active state is changed, and no events (focus/blur) are fired. Also clarifies that fully active does not impact "being rendered" or viewport intersection.

WestonThayer · 2021-12-08T02:31:47Z

I opened #7397 to track my previous question.

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

…nd BFCache, a=testonly Automatic update from web-platform-tests [WPT] BFCache: focus should be kept around BFCache This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} -- wpt-commits: a1e49a05bf46345316fd04bb4b22e5e7e8d9bc70 wpt-pr: 31084

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703}

…nd BFCache, a=testonly Automatic update from web-platform-tests [WPT] BFCache: focus should be kept around BFCache This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} -- wpt-commits: a1e49a05bf46345316fd04bb4b22e5e7e8d9bc70 wpt-pr: 31084

Fixes whatwg#5878. Clarifies that the focused element stays the same and is not reset when a document's fully active state is changed, and no events (focus/blur) are fired. Also clarifies that fully active does not impact "being rendered" or viewport intersection.

This CL adds a test to confirm that, when page gets into and out of BFCache, - Focus should be kept and - blur/focus events are not fired. The current results are Safari: Pass Firefox: Focus remains the same but blur/focus events are fired. Chrome: Focus is lost. See whatwg/html#6696 for other status and implementation bug links etc. Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198456 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#968703} NOKEYCHECK=True GitOrigin-RevId: 60349a6da0ccfa946936e76665ccff67fc9eac22

rakina mentioned this issue Aug 31, 2020

Back-forward cache meta-bug #5880

Open

annevk added topic: focus topic: history labels Aug 31, 2020

domenic added the agenda+ To be discussed at a triage meeting label Feb 25, 2021

past mentioned this issue Mar 11, 2021

Upcoming HTML standard issue triage meeting on 3/4/2021 #6371

Closed

domenic removed the agenda+ To be discussed at a triage meeting label Apr 1, 2021

past mentioned this issue Apr 1, 2021

Upcoming HTML standard issue triage meeting on 4/1/2021 #6481

Closed

rakina mentioned this issue May 19, 2021

Add notes for focus & non-"fully active" documents #6696

Merged

3 tasks

rakina mentioned this issue May 19, 2021

Should last activation timestamp be reset after navigation? #6588

Closed

chromium-wpt-export-bot mentioned this issue Oct 13, 2021

[WPT] BFCache: focus should be kept around BFCache web-platform-tests/wpt#31084

Merged

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 13, 2021

[WPT] BFCache: focus

b3ca010

Bug: 1107415, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 13, 2021

[WPT] BFCache: focus

0d35430

Bug: 1107415, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 13, 2021

[WPT] BFCache: focus

99e559c

Bug: 1107415, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

domenic closed this as completed in #6696 Oct 14, 2021

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Oct 19, 2021

[WPT] BFCache: focus should be kept around BFCache

2d8fc8e

Bug: 1107415, 1253728, whatwg/html#5878 Change-Id: I2bb9a420de19f24d7010917f7e6ce54cba8212fb

domenic mentioned this issue Nov 18, 2021

Focus management for SPA navs WICG/navigation-api#190

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Back-forward cache: Restoring focus #5878

Back-forward cache: Restoring focus #5878

rakina commented Aug 31, 2020 •

edited

Loading

annevk commented Aug 31, 2020

domenic commented Aug 31, 2020

domenic commented Nov 22, 2020

domenic commented Mar 4, 2021

rakina commented May 19, 2021

rniwa commented May 21, 2021

hiroshige-g commented Oct 13, 2021 •

edited

Loading

WestonThayer commented Nov 30, 2021

WestonThayer commented Dec 8, 2021

Back-forward cache: Restoring focus #5878

Back-forward cache: Restoring focus #5878

Comments

rakina commented Aug 31, 2020 • edited Loading

annevk commented Aug 31, 2020

domenic commented Aug 31, 2020

domenic commented Nov 22, 2020

domenic commented Mar 4, 2021

rakina commented May 19, 2021

rniwa commented May 21, 2021

hiroshige-g commented Oct 13, 2021 • edited Loading

WestonThayer commented Nov 30, 2021

WestonThayer commented Dec 8, 2021

rakina commented Aug 31, 2020 •

edited

Loading

hiroshige-g commented Oct 13, 2021 •

edited

Loading