Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden input name=_charset_ case sensitivity #5914

Closed
josepharhar opened this issue Sep 14, 2020 · 3 comments · Fixed by #5948
Closed

Hidden input name=_charset_ case sensitivity #5914

josepharhar opened this issue Sep 14, 2020 · 3 comments · Fixed by #5948
Labels
interop Implementations are not interoperable with each other topic: forms

Comments

@josepharhar
Copy link
Contributor

According to the spec, the check for the _charset_ string in <input type=hidden name="_charset_"> should be case sensitive, but in chrome and safari, the check is case insensitive.

I was going to make the check case sensitive in chrome to match the spec, but I did an HTTPArchive query and found that there are a few sites which use _CHARSET_ instead of _charset_. Considering that I might be breaking some websites by making the check case sensitive, could we instead change the spec to make the check case insensitive?

@annevk
Copy link
Member

annevk commented Sep 15, 2020

It seems reasonable to change this. Could you update the test to check for the exact encoding emitted (as well as expecting an encoding for the case-insensitive matches of course).

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1665014 to track this in Firefox.

@annevk annevk added interop Implementations are not interoperable with each other topic: forms labels Sep 15, 2020
@domenic
Copy link
Member

domenic commented Sep 15, 2020

Note that the section linked here is for authoring conformance requirements, not processing model. The processing model is in https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set:attr-fe-name-charset. (But, they are both case-sensitive and would need updating.)

@josepharhar
Copy link
Contributor Author

Thanks for filing the firefox bug @annevk!
Opened a pr: #5948
Opened a wpt pr: web-platform-tests/wpt#25797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other topic: forms
Development

Successfully merging a pull request may close this issue.

3 participants