Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

" get checked() { return this.getAttribute('che..." #6819

Closed
iahu opened this issue Jul 1, 2021 · 3 comments · Fixed by #6829
Closed

" get checked() { return this.getAttribute('che..." #6819

iahu opened this issue Jul 1, 2021 · 3 comments · Fixed by #6829
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@iahu
Copy link

iahu commented Jul 1, 2021

https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-face-example

get checked() { return this.getAttribute('checked'); }

this line should be

  get checked() { return this.hasAttribute('checked'); }
@domenic domenic added the good first issue Ideal for someone new to a WHATWG standard or software project label Jul 1, 2021
@ayushnau
Copy link

ayushnau commented Jul 3, 2021

hello I would like to contribute in this issue

@Dhriti-Roy
Copy link

hello I want to contribute in this project

@Patil2099 Patil2099 mentioned this issue Jul 6, 2021
Merged
@ayushnau
Copy link

ayushnau commented Jul 7, 2021

I have already made the pull request but don't know how it doesn't get reviewed !!!

domenic pushed a commit that referenced this issue Jul 7, 2021
@Patil2099
Fix custom elements example getter
fdb64fd 
Closes #6819. Closes #6825 by superseding it.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@Patil2099
Fix custom elements example getter
5916dd7 
Closes whatwg#6819. Closes whatwg#6825 by superseding it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix custom elements example getter
5 participants
@domenic @iahu @Dhriti-Roy @ayushnau and others