Unfocusing steps should account for delegatesFocus somehow
#7070
Labels
Comments
|
Makes sense. Are you able to figure out a rough spec patch that would fix this? Either as a PR, or just writing it up informally here and I can translate it, would be great. |
domenic
added
topic: focus
topic: shadow
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Sep 15, 2021
…emilio This intends to address: whatwg/html#7070 Differential Revision: https://phabricator.services.mozilla.com/D125477
|
@domenic I think around step 2 we should say something like "if old focus target is a shadow host, and its shadow root delegates focus, and the currently focused area of a top-level browsing context is a shadow-including descendant of the shadow root, then let old focus target be the currently focused area of a top-level browsing context." Or something like that. |
|
Sounds good. My tentative guess it it should be the very first step, right? Since we probably want to do inert checking/area stuff on the "computed" old focus target, not the original. I'll send a PR shortly. |
domenic
added a commit
that referenced
this issue
Sep 16, 2021
aosmond
pushed a commit
to aosmond/gecko
that referenced
this issue
Sep 18, 2021
…emilio This intends to address: whatwg/html#7070 Differential Revision: https://phabricator.services.mozilla.com/D125477
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Sep 20, 2021
This intends to address: whatwg/html#7070 Differential Revision: https://phabricator.services.mozilla.com/D125477 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1730566 gecko-commit: 8fb7f5a7c65404c7d157e61f29b093c5a50f343d gecko-reviewers: emilio
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Sep 20, 2021
This intends to address: whatwg/html#7070 Differential Revision: https://phabricator.services.mozilla.com/D125477 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1730566 gecko-commit: 8fb7f5a7c65404c7d157e61f29b093c5a50f343d gecko-reviewers: emilio
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this issue
Nov 18, 2021
This intends to address: whatwg/html#7070 Differential Revision: https://phabricator.services.mozilla.com/D125477 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1730566 gecko-commit: 8fb7f5a7c65404c7d157e61f29b093c5a50f343d gecko-reviewers: emilio
dandclark
pushed a commit
to dandclark/html
that referenced
this issue
Dec 4, 2021
* Make it use the shadow tree instead of the flat tree. Closes whatwg#7207. * Make it work with the unfocusing steps symmetrically to the focusing steps. Closes whatwg#7070.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this issue
Jun 3, 2022
* Make it use the shadow tree instead of the flat tree. Closes whatwg#7207. * Make it work with the unfocusing steps symmetrically to the focusing steps. Closes whatwg#7070.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
blur()on a shadow host withdelegatesFocus = trueshould blur content inside the shadow tree. This matches sanity (blur()should undo whatfocus()does) and both WebKit and Blink.However per spec this shouldn't happen.
blur()executes https://html.spec.whatwg.org/#unfocusing-steps, but if you call that on a shadow host with delegatesFocus you bail out here:Unless I'm missing something, since neither https://html.spec.whatwg.org/#current-focus-chain-of-a-top-level-browsing-context or https://html.spec.whatwg.org/#focus-chain deal with
delegatesFocusin any way (and I don't think they should, probably).See https://bugzilla.mozilla.org/show_bug.cgi?id=1730566 for a test-case.
The text was updated successfully, but these errors were encountered: