New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<dialog> UA styles are not interoperable, and should use system colors. #7754
Comments
Err, cc @lilles, sorry for the needless ping at-futhark :) |
WebKit also implements the spec to the letter it seems: https://webkit-search.igalia.com/webkit/rev/ee84898cfec61c56212af2769ca6e7c88d02f4d8/Source/WebCore/css/dialog.css#10-11 |
https://bugzilla.mozilla.org/show_bug.cgi?id=1761611 has tentative patch and tests assuming this won't be too controversial. |
Yeah, I agree with this, I was implementing the spec to the letter. This is something I wanted to bring up after I noticed Chromium used -internal-light-dark(...). +1 for Canvas/CanvasText combo. |
I filed https://bugs.webkit.org/show_bug.cgi?id=238425, will post a patch when WPT is upstream. |
Totally agree canvas/canvastext makes sense. |
Given how fast people converged here, the same people may be interested in #5426 , which proposes making changes to other hard-coded colors. The latest list of to-dos was in #5426 (comment) . Although, looking at how this was resolved, it seems like maybe my step (1) there is not a blocker? After that the thread got hijacked by the color-contrast debate that seems to be raging across multiple repositories... I'm hopeful some strong implementer involvement could get things back on track. |
Fwiw i don't think we want to hardcode the specific colors. For example in Firefox link colors are configurable. We already use system colors for those, which react to dark mode with hopefully enough contrast. |
To be landed when whatwg/html#7754 has a resolution, but I think it should be uncontroversial. Differential Revision: https://phabricator.services.mozilla.com/D142170 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1761611 gecko-commit: 8f2f77d1e339d6d0c0a4e1acb3834ff87e1444c0 gecko-reviewers: morgan
Using system colors improves the behavior for forced colors. whatwg/html#7754 Bug: 1310742 Change-Id: I0d0ce6519efe3b642f26e6a27deb68d302facfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550973 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#986392}
To be landed when whatwg/html#7754 has a resolution, but I think it should be uncontroversial. Differential Revision: https://phabricator.services.mozilla.com/D142170
To be landed when whatwg/html#7754 has a resolution, but I think it should be uncontroversial. Differential Revision: https://phabricator.services.mozilla.com/D142170 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1761611 gecko-commit: 8f2f77d1e339d6d0c0a4e1acb3834ff87e1444c0 gecko-reviewers: morgan
To be landed when whatwg/html#7754 has a resolution, but I think it should be uncontroversial. Differential Revision: https://phabricator.services.mozilla.com/D142170
@emilio right, the problem is that they are hardcoded in the HTML Standard currently. |
Using system colors improves the behavior for forced colors. whatwg/html#7754 Bug: 1310742 Change-Id: I0d0ce6519efe3b642f26e6a27deb68d302facfcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550973 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#986392} NOKEYCHECK=True GitOrigin-RevId: 2d8a17550f1ba47984c62b3216468f027eaabd14
https://html.spec.whatwg.org/#flow-content-3 has:
That's what Firefox implements to the letter, but:
-internal-light-dark(..)
instead).To fix the above two things, I think we should instead make those two lines:
(
background-color
instead ofbackground
because it's cheaper and shouldn't be observable, but...)cc @nt1m @Futhark
The text was updated successfully, but these errors were encountered: