<form method="dialog"> should probably not check for noopener

[nt1m]

According to the spec, we should be checking for the noopener, and then skip to the dialog steps.

https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm:get-an-element's-noopener

I think it probably makes sense to skip to the dialog steps earlier, before we even do any navigation checks, given form[method=dialog] does not involve any navigation.

cc @domenic @annevk

[nt1m]

cc @whatwg/forms too

[annevk]

So currently <form method=dialog rel=noopener> fails to submit (due to an early return) and with this change it would succeed (or at least continue beyond that point). Seems reasonable to me for the reason you state.

Edit: this analysis was incorrect. The problem is that we end up creating a top-level navigable we don't need.

[domenic]

Seems good to me. So this would consist of moving what is currently steps 16 and 23 up to after step 9, I think? That is, we still want to:

• Check "cannot navigate" (multiple times)
• Check sandboxing
• Fire submit events
• Construct the entry list and thus fire formdata events

But we do not want to:

• Bail early if the action="" value is not parseable as a URL
• Call "the rules for choosing a navigable" including potentially creating a new window, consulting target/formtarget, etc.

Would you be up for writing a spec PR and tests PR covering these?

[annevk]

Presumably we just have to move

If the value of method is dialog then jump to the submit dialog steps.

up? Makes sense to ignore action parsing as well. (Ideally we'd not have "jump", but that's a bit more effort.)

[domenic]

Right, that's step 23; step 16 is establishing the value of method.

[smaug----]

@sefeng211

[josepharhar]

Sounds good to me. Based on what I'm reading in chromium it seems like this is what we are already doing.
The check for method=dialog comes before what I believe is the check for the target navigable.

[smaug----]

Looks reasonable. @avandolder

[avandolder]

Yeah, this should also line up with how Gecko already handles submissions - we check for dialog before handling rel values.

[annevk]

FYI, I ended up finding a "bug" in Gecko. It takes the form's action into account. Bug linked from the PR.