You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thinking about this again I think @josepharhar fixed the call sites to always pass an element or a document. And then probably forgot to remove that step.
If true, that also means closeAllOpenPopovers can be inlined now.
In whatwg#8886 I made the endpoint
parameter in hide all popovers until never null by making it either a
document or an element, but I forgot to change this null check to a
document check.
Fixeswhatwg#8963
In #8886 I made the endpoint parameter in hide all popovers until never null by making it either a document or an element, but I forgot to change this null check to a document check.
Fixes#8963.
So "endpoint" can be null, so how does steps 1. & 2. get the document? Does that algorithm need to always take a document as extra argument?
cc @josepharhar @mfreed7 @domenic
The text was updated successfully, but these errors were encountered: