Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: note still talks about anchor attribute #8968

Closed
annevk opened this issue Mar 1, 2023 · 6 comments · Fixed by #9141
Closed

Popover: note still talks about anchor attribute #8968

annevk opened this issue Mar 1, 2023 · 6 comments · Fixed by #9141
Labels
topic: popover The popover attribute and friends

Comments

@annevk
Copy link
Member

annevk commented Mar 1, 2023

@josepharhar @mfreed7 can you take a look at this note? I'm not sure how to accurately reword it.

This eliminates non-showing popovers and self-pointers (e.g. a popover with an anchor attribute that points back to the same popover), and it allows for the construction of a well-formed tree from the (possibly cyclic) graph of connections.

(You can have self-pointers with popovertarget, but I suspect this is about something else.)

@annevk annevk added the topic: popover The popover attribute and friends label Mar 1, 2023
@mfreed7
Copy link
Collaborator

mfreed7 commented Mar 2, 2023

This eliminates non-showing popovers and self-pointers (e.g. a popover with an anchor attribute that points back to the same popover), and it allows for the construction of a well-formed tree from the (possibly cyclic) graph of connections.

How about this:

This eliminates non-showing popovers and self-pointers (e.g. a popover containing an invoking element that points back to the containing popover), and it allows for the construction of a well-formed tree from the (possibly cyclic) graph of connections.

@annevk
Copy link
Member Author

annevk commented Mar 2, 2023

So that means <div id=x popover><button popovertarget=x popover>blah</button></div>, right? Because <button id=x popovertarget=x popover>blah</button> works.

@mfreed7
Copy link
Collaborator

mfreed7 commented Mar 2, 2023

Or even just <div id=x popover><button popovertarget=x></button></div>. I.e. the button doesn't have to be a popover.

@annevk
Copy link
Member Author

annevk commented Mar 2, 2023

Okay, I think that works then.

@annevk
Copy link
Member Author

annevk commented Mar 16, 2023

@mfreed7 are you planning on writing a PR for this?

@mfreed7
Copy link
Collaborator

mfreed7 commented Mar 17, 2023

@josepharhar is working on a PR to add back the anchor attribute, to work with the CSS Anchor Positioning spec. Perhaps he can modify this note (or not?) as part of that PR?

If not, @josepharhar mind just changing the note in the meantime? See the suggested text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: popover The popover attribute and friends
Development

Successfully merging a pull request may close this issue.

2 participants