Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

" autocomplete cols;" missing a semicolon #9347

Closed
Potherca opened this issue May 27, 2023 · 7 comments
Closed

" autocomplete cols;" missing a semicolon #9347

Potherca opened this issue May 27, 2023 · 7 comments
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@Potherca
Copy link

https://html.spec.whatwg.org/multipage/indices.html#elements-3:global-attributes-95

Where it says:

autocomplete cols;

It should say:

autocomplete; cols;

Currently, the semicolon is missing.

@annevk annevk added clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project labels May 31, 2023
@Jatin71544

This comment was marked as spam.

@kaf-lamed-beyt
Copy link
Contributor

Hi @annevk,

I'd love to work on this. Can you assign it to me? Although this will be my first time contributing to this repo. Can you walk me through the folder I need to focus on?

I notice that this change will be reflected on the website, hence my request for a guide.

Screenshot_20230604_184512_Chrome

@annevk
Copy link
Member

annevk commented Jun 5, 2023

Thanks for your interest! In order to fix this you need to change source and be comfortable signing https://participate.whatwg.org/agreement. Instructions are available in the README. We don't assign issues.

@kaf-lamed-beyt
Copy link
Contributor

Awesome! I'll sign the agreement now and go over source If I get stuck. I'll reach out

@kaf-lamed-beyt
Copy link
Contributor

So I've signed the agreement and I've also figured out the exact line that I need to modify.

Around 130,000 ++ or so. I can't remember the exact line number.

At the moment I'm not close to my PC. When I am, I'll make the change and open a PR.

cc: @annevk

@kaf-lamed-beyt
Copy link
Contributor

@annevk I submitted a PR. Please take a look.

@annevk
Copy link
Member

annevk commented Jun 12, 2023

Thanks all, fixed by 52a3734.

@annevk annevk closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

4 participants