chore: add semicolon to textarea autocomplete attribute #9389
Conversation
|
This doesn't look to be in the right place, is it? |
keithamus
added
the
editorial
I think it is. From the issue's description, it says autocomplete is missing the |
source
Outdated
| @@ -130515,7 +130515,7 @@ interface <dfn interface>External</dfn> { | |||
| <td><span data-x="text content">text</span></td> | |||
| <td><span data-x="global attributes">globals</span>; | |||
| <code data-x="attr-fe-autocomplete">autocomplete</code> | |||
There was a problem hiding this comment.
@keithamus means it’s this line that should end with the semicolon (i.e., it should look the same as the rest of them). Line breaks are whitespace in HTML, so prefixing the next line introduces a space in the rendered text that shouldn’t be present.
There was a problem hiding this comment.
Oh! Thanks for clarifying. I'll have that fixed.
There was a problem hiding this comment.
I made the change.
cc: @keithamus @bathos
There was a problem hiding this comment.
I’m not sure the latest commit has improved matters.
There was a problem hiding this comment.
Oh! Maybe I should just close this PR and open another one.
Would that work?
There was a problem hiding this comment.
Yeah you were on the right track with the original commit. You can try to rebase this branch to get back to that commit, or set up a new PR and close this one out.
There was a problem hiding this comment.
Awesome! I'll try rebasing.
Thanks for the guide.
There was a problem hiding this comment.
@keithamus kindly take a look now
There was a problem hiding this comment.
Really close but there are now 2 semicolons when I think there should be one. I’ve added a suggestion which if accepted I think will result in the diff we want.
There was a problem hiding this comment.
Thanks for pointing this out. I've accepted the suggestion.
kaf-lamed-beyt
force-pushed
the
autocomplete-cols
branch
from
01e4991
to
5d1464d
Compare
| <code data-x="attr-fe-autocomplete">autocomplete</code> | ||
| <code data-x="attr-textarea-cols">cols</code>; | ||
| <code data-x="attr-fe-autocomplete">autocomplete</code>; | ||
| ; <code data-x="attr-textarea-cols">cols</code>; |
There was a problem hiding this comment.
I tried accepting the change. But, whenever I try committing, I get this 👇🏼
|
Ok this LGTM! @annevk I think this one is good to merge? Does @kaf-lamed-beyt need to sign the participation agreement in order for this one to land? |
|
Awesome! 🚀 I signed the participation agreement already though. |
There was a problem hiding this comment.
Thanks @kaf-lamed-beyt and congratulations on your first contribution!
And thanks a lot @keithamus (and @bathos!) for helping out, much appreciated!
|
Ayy!! Thanks, @annevk. I look forward to doing more |
(See WHATWG Working Mode: Changes for more details.)
/indices.html ( diff )