Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.clientInformation is Replaceable in Chromium and WebKit #9687

Closed
annevk opened this issue Sep 5, 2023 · 0 comments · Fixed by #9688
Closed

window.clientInformation is Replaceable in Chromium and WebKit #9687

annevk opened this issue Sep 5, 2023 · 0 comments · Fixed by #9688
Labels
normative change

Comments

@annevk
Copy link
Member

annevk commented Sep 5, 2023

This attribute was standardized in #2379, but [Replaceable] was not standardized. I tend to think we should add the attribute given Chromium and WebKit were copied in the first place.

cc @domenic @saschanaz @zcorpan
@annevk annevk mentioned this issue Sep 5, 2023
Merged
annevk added a commit that referenced this issue Sep 5, 2023
@annevk
Mark window.clientInformation [Replaceable]
ff2aa04 
Not adding this was an oversight in #2379 as far as I can tell.

Tests: ...

Fixes #9687.
@annevk annevk mentioned this issue Sep 5, 2023
Merged
4 tasks
webkit-commit-queue pushed a commit to annevk/WebKit that referenced this issue Sep 5, 2023
@annevk
Implement window.clientInformation in terms of window.navigator
9c5a4cd 
https://bugs.webkit.org/show_bug.cgi?id=261142
rdar://114971280

Reviewed by Tim Nguyen.

Do so via IDL and as it has since been standardized, move it next to
navigator where it is in the HTML Standard. Filed
whatwg/html#9687 to standardize the
Replaceable attribute.

* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalDOMWindow.idl:

Canonical link: https://commits.webkit.org/267625@main
annevk added a commit that referenced this issue Sep 6, 2023
@annevk
Mark window.clientInformation [Replaceable]
4204818 
Not adding this was an oversight in #2379 as far as I can tell.

Tests: web-platform-tests/wpt#41819.

Fixes #9687.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
normative change
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark window.clientInformation [Replaceable] whatwg/html
1 participant
@annevk