Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML's URL-parser wrapper in EventSource #9728

Closed
domenic opened this issue Sep 13, 2023 · 1 comment
Closed

Use HTML's URL-parser wrapper in EventSource #9728

domenic opened this issue Sep 13, 2023 · 1 comment
Labels
clarification Standard could be clearer topic: eventsource

Comments

@domenic
Copy link
Member

domenic commented Sep 13, 2023

https://html.spec.whatwg.org/commit-snapshots/43859d47e14b1e4b484b9534fd4469f270032494/#the-eventsource-interface

Let urlRecord be the result of parsing url with settings's API base URL and settings's API URL character encoding.

This should use the wrapper operations (worked on recently in #9719 and friends).

This is also the only "read" operation in HTML on "API URL character encoding" besides those wrappers, so after we migrate this we could probably remove "API URL character encoding".
@domenic domenic added clarification Standard could be clearer topic: eventsource labels Sep 13, 2023
@annevk
Copy link
Member

annevk commented Sep 18, 2023

It's also being called by service workers, but I think for workers it's not needed so I think we could indeed mostly get rid of that, which would be nice.

@annevk annevk closed this as completed in d6ce12a Sep 19, 2023
mfreed7 pushed a commit to mfreed7/html that referenced this issue Oct 11, 2023
@annevk
Editorial: remove API URL character encoding
de62bb6 
This makes it clearer that only when Document objects are involved encoding-parsing a URL will do something special.

Fixes whatwg#9728.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer topic: eventsource
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk