New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable PageSwapEvent.activation when navigation has cross-origin red… #10207

Merged

domenic merged 4 commits into whatwg:main from noamr:pageswap-xor

Mar 27, 2024

Contributor

noamr commented Mar 15, 2024 •

edited by pr-preview bot

…irects

At least two implementers are interested (and none opposed):
- Chromium (implemented)
- Gecko (as part of the pageswap event) The pageconceal event (part of cross-document view-transitions) mozilla/standards-positions#969
Tests are written and can be reviewed and commented upon at:
- https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-push-with-cross-origin-redirect.sub.html?label=experimental&label=master&aligned
Implementation bugs are filed:
- Chromium: implemented
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1881438
- WebKit: https://bugs.webkit.org/show_bug.cgi?id=269904
MDN issue is filed: being tackled as part of documenting pageswap
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )

noamr added 2 commits

March 15, 2024 13:23


          Disable PageSwapEvent.activation when navigation has cross-origin red…

7f0225d

…irects


          Add missing doc

1c813e5

khushalsagar reviewed

View reviewed changes

source Show resolved Hide resolved


          Refine to only exclude bfcache

d74edea

Contributor Author

noamr commented Mar 25, 2024

@domenic does this seem reasonable? If so we'll add the tests etc.

domenic reviewed

View reviewed changes

Member

domenic left a comment

Editorial issues only

source Show resolved Hide resolved

source Outdated

+                    href="#note-bfcache">bfcache</a>.</p>
+                   </li>
+                  </ul>
+                  <p>then:</p>

Member

domenic Mar 26, 2024

Newline between </ul> and <p>

Contributor Author

noamr Mar 26, 2024

Done


          editorials

domenic approved these changes

View reviewed changes

domenic added the topic: navigation label

domenic merged commit c1b467a into whatwg:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment