Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn that the XML syntax is not recommended #10239

Merged
merged 1 commit into from Apr 8, 2024
Merged

Warn that the XML syntax is not recommended #10239

merged 1 commit into from Apr 8, 2024

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Apr 1, 2024 •
edited by pr-preview bot

domenic
domenic approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love all of the wording here. Let's give others a few days to comment, but I'm in favor.

@domenic domenic added clarification Standard could be clearer topic: parser labels Apr 2, 2024
@MrHBS
Copy link

MrHBS commented Apr 3, 2024

Why not just move all the xml stuff into the obsolete section?

@domenic domenic merged commit ebbb1c0 into main Apr 8, 2024
2 checks passed
@domenic domenic deleted the sideshowbarker/xml-syntax-not-recommended branch April 8, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: parser
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sideshowbarker @MrHBS @domenic @annevk