Add new canvas rendering context: ImageBitmapRenderingContext #1028
Conversation
|
Summoning @mephisto41 who implemented this in Gecko. Other than the sizing behavior, is there anything in the PR that does not match the current implementation? |
| <th>"<dfn><code data-x="canvas-context-bitmaprenderer">bitmaprenderer</code></dfn>" | ||
| <td> | ||
|
|
||
| Follow the <span>image bitmap context creation algorithm</span> defined in the section |
There was a problem hiding this comment.
This is not xlinking to anything. (Yes, it sucks that the build tools fail to notify for this.)
|
Really nice clean slice of OffscreenCanvas to introduce. Lots of editorial tweaks but overall solid. Do you think it would benefit developers to have an example of this in use, in order to show how this renders the ImageBitmap into a canvas without doubling memory usage, as noted in https://www.w3.org/Bugs/Public/show_bug.cgi?id=25647 ? I would put it at the end, after the w-nodev section ends. |
|
Sorry for late reply. I think the spec looks good. |
annevk
added
normative change
addition/proposal
|
New commit. Addressed all comments made up to now.
I was thinking of adding an example once the the spec for OffscreenCanvas is in place, to show the two interfaces working together with ImageBitmaps being passed from Worker to main thread for display. However, I agree with the more general underlying point you are making that we should give more context to developers, so I added a brief intro paragraph between the section title and the IDL. |
|
New commit:
|
| @@ -59795,7 +59795,8 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</pre> | |||
| what kind of rendering context it is, a <code>canvas</code> also has a <dfn | |||
| data-x="concept-canvas-context-mode">canvas context mode</dfn>, which is initially <dfn | |||
| data-x="concept-canvas-none">none</dfn> but can be changed to either <dfn | |||
| data-x="concept-canvas-2d">2d</dfn> or <dfn | |||
| data-x="concept-canvas-2d">2d</dfn>, <dfn | |||
| data-x="concept-canvas-bitmaprenderer">bitmaprenderer</dfn> or <dfn | |||
There was a problem hiding this comment.
nit: comma after bitmaprenderer</dfn>
| <ol> | ||
|
|
||
| <li><p>If the algorithm was passed some arguments, let <var>arg</var> be the first such | ||
| argument. Otherwise, let <var>arg</var> be <i>undefined</i>.</p></li> |
There was a problem hiding this comment.
This sentence was copy-pasted from the 2d context creation algorithm. Will remove <i> there as well.
|
Looks good, those last few nits should do it from me. I'll merge after they're addressed. Nice intro paragraph. |
This change introduces the ImageBitmapRenderingContext interface. This is part of the larger OffscreenCanvas feature proposal found here: https://wiki.whatwg.org/wiki/OffscreenCanvas The documentation for the implementation by Mozilla, which is experimental at this time, can be found here: https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmapRenderingContext
|
Done. |
This change introduces the ImageBitmapRenderingContext interface. This is part of the larger OffscreenCanvas feature proposal found here: https://wiki.whatwg.org/wiki/OffscreenCanvas The documentation for the implementation by Mozilla, which is experimental at this time, can be found here: https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmapRenderingContext PR: #1028
|
Awesome!! Found a couple more un- |
|
Yay! Thanks for the responsive reviewing! |
It needs to list ImageBitmapRenderingContext. Missed in #1028.
It needs to list ImageBitmapRenderingContext. Missed in #1028.
It needs to list ImageBitmapRenderingContext. Missed in whatwg#1028.
This change introduces the ImageBitmapRenderingContext interface.
This is part of the larger OffscreenCanvas feature proposal found here:
https://wiki.whatwg.org/wiki/OffscreenCanvas
The documentation for the implementation by Mozilla, which is
experimental at this time, can be found here:
https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmapRenderingContext