Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Upstream the createContextualFragment method from DOM Parsing #10283

Merged
merged 3 commits into from Apr 24, 2024
Merged

Editorial: Upstream the createContextualFragment method from DOM Parsing #10283

merged 3 commits into from Apr 24, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Apr 17, 2024 •
edited by pr-preview bot

lukewarlow
lukewarlow commented Apr 17, 2024
View reviewed changes
source Outdated Show resolved Hide resolved
lukewarlow
lukewarlow commented Apr 17, 2024
View reviewed changes
source Outdated Show resolved Hide resolved
lukewarlow
lukewarlow commented Apr 17, 2024
View reviewed changes
source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow changed the title Upstream the createContextualFragment method from DOM Parsing Editorial: Upstream the createContextualFragment method from DOM Parsing Apr 17, 2024
@lukewarlow lukewarlow mentioned this pull request Apr 17, 2024
Merged
domenic
domenic reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments, although several of the stylistic issues with insertAdjacentHTML() apply here too and I didn't comment on them.

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow added addition/proposal New features or enhancements topic: parser labels Apr 18, 2024
@lukewarlow lukewarlow force-pushed the domparsing-createcontextualfragment branch from ece17d4 to 2e7eaec Compare April 18, 2024 10:29
@lukewarlow lukewarlow mentioned this pull request Apr 18, 2024
Open
5 tasks
@lukewarlow lukewarlow force-pushed the domparsing-createcontextualfragment branch from 2e7eaec to 6a17bbd Compare April 19, 2024 10:13
@lukewarlow lukewarlow marked this pull request as ready for review April 19, 2024 10:13
@lukewarlow lukewarlow requested a review from domenic April 19, 2024 10:13
domenic
domenic reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with editorial nits

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@lukewarlow lukewarlow requested a review from domenic April 22, 2024 13:40
domenic
domenic reviewed Apr 23, 2024
View reviewed changes
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
annevk
annevk reviewed Apr 23, 2024
View reviewed changes
source Show resolved Hide resolved
@lukewarlow lukewarlow requested a review from domenic April 23, 2024 17:08
@domenic domenic merged commit 69f5a4a into whatwg:main Apr 24, 2024
2 checks passed
domenic pushed a commit to w3c/DOM-Parsing that referenced this pull request Apr 24, 2024
@lukewarlow
Remove createContextualFragment() method
272e8ff 
This has been moved to the HTML Standard in whatwg/html#10283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
addition/proposal New features or enhancements topic: parser
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukewarlow @domenic @annevk