Remove MediaController and media element's mediagroup attribute #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. We even gave an extra month after the April 2016 deadline; oh well... |
|
FWIW, on my part it was the intention to wait until the end of April, to allow for the least unfavorable interpretation of the message. |
|
With the removal of the step including "if jumped is true", an earlier assignment of jumped becomes pointless, can you remove that as well? |
|
The "effective playback rate" concept becomes redundant, and was introduced with 66c5b32. Can you revert it back the references to just |
|
You didn't change this but it shows up in the diff: In five other cases, the "ended playback" concept is linked as "playback has ended" and I think that would read better with the preceding bit removed. |
|
LGTM % above nits. Unfortunately the diff was too big to comment inline, but I hope you can figure out what I mean. |
Merged
queengooborg
added a commit
to queengooborg/browser-compat-data
that referenced
this pull request
Oct 20, 2023
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `MediaController` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/MediaController Additional Notes: While the feature was removed from the spec (see whatwg/html#1225), we still currently document HTMLMediaElement.controller, which returns this interface, so I figured it would be sensible to add this to BCD.
Elchi3
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Oct 29, 2023
* Add missing MediaController API feature This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `MediaController` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/MediaController Additional Notes: While the feature was removed from the spec (see whatwg/html#1225), we still currently document HTMLMediaElement.controller, which returns this interface, so I figured it would be sensible to add this to BCD. * standard_track: true -> false
Elchi3
pushed a commit
to Elchi3/browser-compat-data
that referenced
this pull request
Nov 14, 2023
* Add missing MediaController API feature This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `MediaController` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/MediaController Additional Notes: While the feature was removed from the spec (see whatwg/html#1225), we still currently document HTMLMediaElement.controller, which returns this interface, so I figured it would be sensible to add this to BCD. * standard_track: true -> false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 66c5b32 due to lack of
implementer interest. This is unfortunate as simultaneous playback of
multiple media elements is impossible to do correctly without it.
Hopefully an alternative solution with broader support can be found
going forward.
Fixes #192.