Remove <style scoped> #1226
Merged
Remove <style scoped> #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
style-scoped-removal
branch
from
5f55baa
to
5993b94
Compare
| text-decoration: underline; | ||
| } | ||
| </style> | ||
| <pre> |
There was a problem hiding this comment.
Remove this newline after <pre>? It's inconsistent with what we do elsewhere.
This reverts 29cf39d and many follow-up refinement commits due to lack of implementer interest. Most of the use cases served by <style scoped> are better served by <style> elements inside a shadow root (although the features do work differently, in that shadow DOM enforces isolation from the cascade, whereas <style scoped> does not). Fixes #552.
domenic
force-pushed
the
style-scoped-removal
branch
from
5993b94
to
47154b5
Compare
|
Rebased and problems fixed |
Merged
ExplodingCabbage
added a commit
to ExplodingCabbage/html
that referenced
this pull request
Jul 7, 2016
These were true when the index of elements was introduced, but obsoleted when whatwg#1226 removed the scoped attribute. Resolves whatwg#1521
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
These were true when the index of elements was introduced, but obsoleted when whatwg#1226 removed the scoped attribute. Fixes whatwg#1521.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 29cf39d and many follow-up
refinement commits due to lack of implementer interest. Most of the use
cases served by
<style scoped>are better served by<style>elementsinside a shadow root (although the features do work differently, in
that shadow DOM enforces isolation from the cascade, whereas
<style scoped>does not).Fixes #552.
This could use some careful review with regard to the changed examples.