Remove form.requestAutocomplete() #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the payment API is not a real replacement as |
| mismatch">suffer from a step mismatch</span>. Except when <span | ||
| data-x="concept-fe-autofill">autofilling</span> for <code | ||
| data-x="dom-form-requestAutocomplete">requestAutocomplete()</code>, a user agent prefilling a form | ||
| mismatch">suffer from a step mismatch</span>. A user agent prefilling a form | ||
| control's <span data-x="concept-fe-value">value</span> must not cause that control to <span |
There was a problem hiding this comment.
Seems this needs to be rewrapped.
domenic
force-pushed
the
requestautocomplete-removal
branch
from
a903c98
to
1ca0fcb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 321659e due to lack of
implementer interest and low adoption, as discussed in #1207. Hopefully
the payment request API will provide an alternative that gets more
implementation and adoption.
Fixes #1207.
I did some investigation and it looks like everything else autocomplete related is orthogonal to requestAutocomplete(); the original commit that introduced it did not introduce any new concepts outside of that section. For example, the "autofill expectation mantle" vs. "autofill anchor mantle" distinction was pre-existing, and presumably reflects real implementation behavior differences for hidden fields vs. not---it wasn't just something added to define the interaction of hidden fields and requestAutocomplete.