Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table hspace/vspace attribute styling #13

Merged
merged 1 commit into from Aug 28, 2015

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 28, 2015

One last PR before I go to sleep...


These were never implemented in IE and Opera, and only in quirks mode in Firefox. They were recently removed from Chrome (https://code.google.com/p/chromium/issues/detail?id=277080).

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=23039.


Careful review appreciated to make sure I found everywhere these were relevant.

Also, I guess Safari still implements this, which is sad. We have a similar situation with showModalDialog.

These were never implemented in IE and Opera, and only in quirks mode in Firefox. They were recently removed from Chrome (https://code.google.com/p/chromium/issues/detail?id=277080).

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=23039.
@annevk
Copy link
Member

annevk commented Aug 28, 2015

LGTM

@domenic domenic merged commit a3ef0d1 into whatwg:master Aug 28, 2015
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jan 29, 2017
@zcorpan
Copy link
Member

zcorpan commented Jan 29, 2017

https://bugs.webkit.org/show_bug.cgi?id=120133
https://bugzilla.mozilla.org/show_bug.cgi?id=725646

Test: web-platform-tests/wpt#4649

@domenic domenic deleted the remove-hspace-vspace branch January 29, 2017 22:12
rniwa pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants