Do not throw for zero colgroup/col.span and textarea.rows/cols #1693
Conversation
Instead, fall back to the default value. For col/colgroup, 3/4 engines do not throw; this aligns with the majority. For textarea, 2/4 engines do not throw, and Firefox would like to align with not throwing. More detail at #1200 (comment). Fixes #1200.
domenic
added
normative change
compat
|
Hold off, web platform tests reveal this isn't actually how it works. It looks like the content attribute gets set to 0 but on getting the IDL attribute converts that to 1. |
domenic
added
the
do not merge yet
|
OK, so WebKit does something reasonable that matches this spec, whereas everyone else deviates from the spec in strange ways. I suspect that at least Chrome's deviations are due to not having a good implementation of the 2147483647 wrapping or of default value fallback on getting. We should merge this and then everyone should work to pass the web platform tests that I'm about to send. |
domenic
removed
the
do not merge yet
This reflects the conclusion of whatwg/html#1200 as in whatwg/html#1693.
| successful, and the value is in the range 1 to 2147483647 inclusive, the resulting value must be | ||
| returned. If, on the other hand, it fails or returns an out of range value, or if the attribute is | ||
| absent, the default value must be returned instead. On setting, first, if the new value is in the | ||
| range 1 to 2147483647, then let <var>n</var> be the new value, otherwise let <var>n</var> be the |
There was a problem hiding this comment.
should mention inclusive here too (style I used elsewhere was "the range x to y, inclusive," btw)
There was a problem hiding this comment.
hmm I guess the current style is to not do that, although if you search for "the range" it seems HTML has all kinds of styles
|
LGTM |
Instead, fall back to the default value.
For col/colgroup, 3/4 engines do not throw; this aligns with the
majority. For textarea, 2/4 engines do not throw, and Firefox would like
to align with not throwing. More detail at
#1200 (comment).
Fixes #1200.
I think we got general agreement on this direction in #1200, so we only need editor review to land this. But /cc @cdumez @rniwa @ayg @smaug---- who were involved in the thread.
I will also work on some web platform tests for these.