Make table.deleteRow(-1) a no-op when there are no rows #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge before #1890 as the commit message claims to copy wording that that commit changes. |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 18, 2016
This copies the wording of tbody.deleteRow, with "its parent" instead of "this element". The previous wording would throw for this case. Tests: web-platform-tests/wpt#4001
foolip
force-pushed
the
deleteRow-minus-one
branch
from
64964f7
to
9528880
Compare
|
@rwlbuis, care to review this and the test? |
rwlbuis
approved these changes
Oct 18, 2016
domenic
added
normative change
compat
|
lgtm. It is best to be consistent. |
|
Thanks all, now merging this and web-platform-tests/wpt#4001 |
|
Chromium change is https://codereview.chromium.org/2427963004/ (no bug, if one is created it'll be linked from there) @cdumez, can you link to WebKit change when it lands? Filed Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/9440419/ |
|
WebKit issue: https://bugs.webkit.org/show_bug.cgi?id=163746 |
kisg
pushed a commit
to paul99/webkit-mips
that referenced
this pull request
Oct 20, 2016
https://bugs.webkit.org/show_bug.cgi?id=163746 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Import test coverage from: - web-platform-tests/wpt#4001 * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html: * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html: * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html: Source/WebCore: Make table.deleteRow(-1) a no-op when there are no rows, instead of throwing: - whatwg/html#1924 This is more consistent with the behavior of tbody.deleteRow(-1) and tr.deleteCell(-1). This is also consistent with Gecko. Blink is doing the same change via: - https://codereview.chromium.org/2427963004/ No new tests, updated existing tests. * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@207640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=163746 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Import test coverage from: - web-platform-tests/wpt#4001 * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html: * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html: * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell-expected.txt: * web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html: Source/WebCore: Make table.deleteRow(-1) a no-op when there are no rows, instead of throwing: - whatwg/html#1924 This is more consistent with the behavior of tbody.deleteRow(-1) and tr.deleteCell(-1). This is also consistent with Gecko. Blink is doing the same change via: - https://codereview.chromium.org/2427963004/ No new tests, updated existing tests. * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): Canonical link: https://commits.webkit.org/181525@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the wording of tbody.deleteRow, with "its parent" instead
of "this element". The previous wording would throw for this case.
Tests: web-platform-tests/wpt#4001