Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <link rel=serviceworker>+associated attributes #2356

Merged
merged 3 commits into from Feb 15, 2017

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Feb 13, 2017

This change defines the <link rel=serviceworker> link type and its
associated scope, workertype, and usecache content attributes, as
well as adding the corresponding scope, workerType, and useCache
IDL attributes to the HTMLLinkElement interface definition.

This change defines the <link rel=serviceworker> link type and its
associated “scope”, “workertype”, and “usecache” content attributes, as
well as adding the corresponding “scope”, “workerType”, and “useCache”
IDL attributes to the HTMLLinkElement interface definition.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. I pushed a couple fixup commits; let me know what you think. Notably I changed workertype to be an enumerated attribute since that matches other similar attributes. That means we would update the service worker spec to refer to the states instead of the attribute value directly, which should be reasonably easy.

/cc @jungkees

@domenic domenic added addition/proposal New features or enhancements and removed normative change labels Feb 15, 2017
@sideshowbarker
Copy link
Contributor Author

Great stuff. I pushed a couple fixup commits; let me know what you think.

All looks great to me—thanks much

Notably I changed workertype to be an enumerated attribute since that matches other similar attributes.

Thanks, yeah I had not been sure what was best to do there given that we I couldn’t see how we could put state definitions for for the corresponding states just in the HTML spec

That means we would update the service worker spec to refer to the states instead of the attribute value directly, which should be reasonably easy.

OK yes I’ll try to put together a Service Worker PR for that myself (unless @jungkees or somebody else gets to it first)

@domenic domenic merged commit c5d4f5c into master Feb 15, 2017
@domenic domenic deleted the sideshowbarker/serviceworker-link-type branch February 15, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants