Link to "run the fullscreen rendering steps" in Fullscreen #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zcorpan, PTAL? "rendering steps" is a bit of a misnomer as it only fires events, if you have a better name I'll take it. |
foolip
force-pushed
the
run-the-fullscreen-rendering-steps
branch
from
c503df8
to
ca65ca4
Compare
zcorpan
approved these changes
Jun 15, 2017
|
How about just "run the fullscreen steps"? Or "run the fullscreen animation frame steps"? |
|
run the fullscreen steps SGTM. |
|
In CSSOM View I say "This section integrates with the event loop defined in HTML. [HTML]" before the relevant algorithm to clarify what it's for. |
foolip
added a commit
to whatwg/fullscreen
that referenced
this pull request
Jun 15, 2017
Matches whatwg/fullscreen#94. Fixes the fullscreen part of #707. Drive-by: re-wrap lines to 100 columns.
foolip
force-pushed
the
run-the-fullscreen-rendering-steps
branch
from
ca65ca4
to
c1b088a
Compare
|
Renamed in whatwg/fullscreen#94 and updated this to match, LGTY? |
|
Didn't add "Editorial:" to this one since it actually adds a real code path to HTML instead of calling into the void. |
foolip
added a commit
to whatwg/fullscreen
that referenced
this pull request
Jun 15, 2017
|
The fullscreen PR was reviewed and merged, so I'll just go ahead with this, just a trivial rename since review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in whatwg/fullscreen#92.
Fixes the fullscreen part of #707.
Drive-by: re-wrap lines to 100 columns.