Update textarea textContent/defaultValue/value interaction #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2752, where it was revealed that most browsers do not care about the textContent of a textarea, but instead about its child text content. That is, if you use the DOM APIs to insert a child element into the textarea element, its text does not show up for editing or as part of the value and defaultValue properties (even though it shows up in textContent). This moves to a model where textareas operate entirely on the child text content. This matches Blink and Gecko, and somewhat matches WebKit. This also fixes #2750, by using the newly-introduced "child text content change steps" hook introduced to DOM in whatwg/dom#466.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 15, 2017
domenic
added
the
do not merge yet
zcorpan
approved these changes
Jun 19, 2017
|
Looks good to me, fwiw. |
domenic
added
interop
|
Filed:
(Firefox passes all tests at web-platform-tests/wpt#6256. Although those tests still need review.) |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 27, 2017
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2752, where it was revealed that most browsers do not care
about the textContent of a textarea, but instead about its child text
content. That is, if you use the DOM APIs to insert a child element into
the textarea element, its text does not show up for editing or as part
of the value and defaultValue properties (even though it shows up in
textContent).
This moves to a model where textareas operate entirely on the child text
content. This matches Blink and Gecko, and somewhat matches WebKit.
This also fixes #2750, by using the newly-introduced "child text content
change steps" hook introduced to DOM in
whatwg/dom#466.
/cc @bzbarsky @zcorpan @tkent-google @cdumez @travisleithead
Tests: web-platform-tests/wpt#6256 (managed to find a Chrome bug!)
Do not merge yet until DOM PR it depends on is approved/merged.