Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify exception catching language #2843

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Clarify exception catching language #2843

merged 1 commit into from
Jul 19, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Jul 17, 2017

Closes #2842, by explicitly using the word "catch" when catching
exceptions. This also aligns better with Infra's conventions.

This also cleans up a number of instances where we explicitly propagate
exceptions, which per Infra is not necessary; instead we simply note
parenthetically that the operations in question can throw.

/cc @EdgarChen @bzbarsky @annevk

Closes #2842, by explicitly using the word "catch" when catching
exceptions. This also aligns better with Infra's conventions.

This also cleans up a number of instances where we explicitly propagate
exceptions, which per Infra is not necessary; instead we simply note
parenthetically that the operations in question can throw.
@domenic domenic added the clarification Standard could be clearer label Jul 17, 2017
@annevk
Copy link
Member

annevk commented Jul 18, 2017

We should maybe level some of this language up to Infra?

@domenic
Copy link
Member Author

domenic commented Jul 18, 2017

It kind of is already:

"Throw" will make the caller automatically rethrow the given value, if any, and thereby terminate the caller’s algorithm. Using prose the caller has the ability to "catch" the exception and perform another action.

@bzbarsky
Copy link
Contributor

The proposed changes look pretty good to me at first glance. Thank you!

@annevk annevk merged commit 5a2087f into master Jul 19, 2017
@annevk annevk deleted the catch-exception-clearer branch July 19, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

Successfully merging this pull request may close these issues.

None yet

3 participants