Skip to content

Editorial: list replaced elements#2857

Merged
annevk merged 1 commit into
masterfrom
annevk/replaced-elements
Jul 29, 2017
Merged

Editorial: list replaced elements#2857
annevk merged 1 commit into
masterfrom
annevk/replaced-elements

Conversation

@annevk
Copy link
Copy Markdown
Member

@annevk annevk commented Jul 21, 2017

@annevk
Copy link
Copy Markdown
Member Author

annevk commented Jul 21, 2017

@cvrebert care to review?

@cvrebert
Copy link
Copy Markdown
Member

cvrebert commented Jul 21, 2017

Is <map> missing from https://html.spec.whatwg.org/#hidden-elements ? It seems to be treated as display:none in practice, like <area>. (I was checking whether image maps might be replaced.)

@annevk
Copy link
Copy Markdown
Member Author

annevk commented Jul 22, 2017

When I write <map>x</map>y it renders xy.

domenic
domenic approved these changes Jul 29, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might make this just a normal p, not a note, as I think statements of fact are a bit nicer that way. But LGTM either way.

@cvrebert
Copy link
Copy Markdown
Member

cvrebert commented Jul 29, 2017 •
edited
Loading

Ah, I clearly didn't try a wacky enough <map> example. Nevermind then.
LGTM.

@annevk
Copy link
Copy Markdown
Member Author

annevk commented Jul 29, 2017

I prefer it like this since it's just a summary of facts.

@annevk annevk merged commit fb00453 into master Jul 29, 2017
@annevk annevk deleted the annevk/replaced-elements branch July 29, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annevk @cvrebert @domenic