Fix some variable usage in navigate #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jul 26, 2017
| @@ -82113,7 +82113,7 @@ State: <OUTPUT NAME=I>1</OUTPUT> <INPUT VALUE="Increment" TYPE=BUTTON O | |||
| <var>browsingContext</var>, and <var>reservedEnvironment</var>.</p></li> | |||
| </ol> | |||
|
|
|||
| <p>To <dfn data-export="">process a navigate response</dfn>, given a <span | |||
| <p>To <dfn data-export="">process a navigate response</dfn>, given null or a <span | |||
| data-x="concept-request">request</span> <var>request</var>, a <span | |||
There was a problem hiding this comment.
I think I prefer "a request or null request"
There was a problem hiding this comment.
Search for "null or" throughout Fetch. I'd rather stick with precedent unless there's a compelling reason. (I also think it's somewhat better to call out the exceptional case first, but YMMV.)
There was a problem hiding this comment.
I guess I am used to programming languages or IDL where it's syntax like int? (i.e. "int or null"). But it does seem that even in HTML we have more "null or" than "or null" (in the context of type declarations, at least).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.