Make U+0000 a parse error in bogus comment and bogus DOCTYPE states #2939
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't we do the same for bogus comments that come from "Anything else" branch of End tag open state? |
|
That already says to reconsume in the bogus comment state. |
|
Indeed. lgtm then. |
zcorpan
added
the
needs tests
zcorpan
added a commit
to html5lib/html5lib-tests
that referenced
this pull request
Aug 18, 2017
zcorpan
added a commit
to html5lib/html5lib-tests
that referenced
this pull request
Aug 18, 2017
zcorpan
added a commit
to html5lib/html5lib-tests
that referenced
this pull request
Aug 22, 2017
zcorpan
removed
the
needs tests
Also make sure to reconsume instead of switching to the bogus DOCTYPE state so that a U+0000 that causes the parser to enter the bogus DOCTYPE state is itself caught as a parse error. Fixes #2684. Tests: html5lib/html5lib-tests#103
zcorpan
force-pushed
the
zcorpan/parse-error-null-bogus-states
branch
from
8ab7474
to
9d4cc4f
Compare
|
Tests are now merged: html5lib/html5lib-tests#103 This PR can be merged when checks have completed. |
JonathanO
added a commit
to JonathanO/html-tokenizer
that referenced
this pull request
Aug 24, 2017
Brings us up to date with whatwg/html#2939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to reconsume instead of switching to the bogus
DOCTYPE state so that a U+0000 that causes the parser to enter the
bogus DOCTYPE state is itself caught as a parse error.
Fixes #2684.
Tests: html5lib/html5lib-tests#103
@whatwg/html-parser