[OffscreenCanvas] Throw when resizing placeholder #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to set the width or height attribute of a canvas element after it has transferred controll to an OffscreenCanvas should throw an exception. Before this change, the behavior was to silently ignore changes to these attributes, which was not clear because that case was not specifically mentioned in the spec.
|
cc @whatwg/canvas @juj |
|
FYI: The corresponding web-platform-test is tweaked with this change (via Chromium -> wpt sync): https://chromium-review.googlesource.com/c/612513 |
|
That text you added is informative and has no requirements. You probably want to use must somewhere. |
|
Looks okay. At some point we should just define the width/height getter/setter as four distinct algorithms. Otherwise the execution order gets unwieldy and we get ambiguities. |
|
Coincidentally, Firefox already throws an exception, though the error message needs improving. The relevant bug is this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1389090 |
Agreed. |
zhenyao
pushed a commit
to KhronosGroup/WebGL
that referenced
this pull request
Aug 22, 2017
* Fix offscreencanvas-resize test to comply with spec This fix covers two spec compliance issues: 1) When an OffscreenCanvas is resized, its size must propagate to the placeholder canvas's width and height attributes; 2) Setting the width and height attributes on a placeholder canvas throws an exception. Related spec change: whatwg/html#2951 * Remove trailing whitespace
domenic
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to set the width or height attribute of a canvas
element after it has transferred controll to an OffscreenCanvas
should throw an exception. Before this change, the behavior was
to silently ignore changes to these attributes, which was not clear
because that case was not specifically mentioned in the spec.