Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Disambiguate focus() and blur() for Window and HTMLElement #3138

Merged
merged 2 commits into from
Oct 20, 2017

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 17, 2017

Add data-for="" attributes as appropriate. This should help other
specs (in this case CSSOM View) cross-referencing these terms.


cc @tabatkins

The link error in cssom-view I'm trying to fix here is:

LINK ERROR: Multiple possible 'focus()' idl refs for 'HTMLElement'.
Arbitrarily chose https://html.spec.whatwg.org/multipage/interaction.html#dom-focus
The following refs show up multiple times in their spec, in a way that Bikeshed can't distinguish between. Either create a manual link, or ask the spec maintainer to add disambiguating attributes (usually a for='' attribute to all of them).
spec:html; type:method; for:HTMLElement; text:focus()
  https://html.spec.whatwg.org/multipage/interaction.html#dom-focus
  https://html.spec.whatwg.org/multipage/interaction.html#dom-window-focus
<a data-link-type="idl" data-lt="focus()" data-link-for="HTMLElement">focus()</a>
 ✔  Successfully generated, with 1 linking errors

Add data-for="" attributes as appropriate. This should help other
specs (in this case CSSOM View) cross-referencing these terms.
@domenic
Copy link
Member

domenic commented Oct 17, 2017

Isn't it data-dfn-for?

@zcorpan
Copy link
Member Author

zcorpan commented Oct 17, 2017

https://tabatkins.github.io/bikeshed/#dfn-contract ... yes. Will fix. There were some more data-fors also.

@tabatkins
Copy link
Collaborator

👍 after fixing the attribute name

@domenic domenic merged commit fde9931 into master Oct 20, 2017
@domenic domenic deleted the zcorpan/export-focus branch October 20, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants